From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125641 invoked by alias); 22 Sep 2017 15:40:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125436 invoked by uid 89); 22 Sep 2017 15:40:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 15:40:04 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7707FC04B318; Fri, 22 Sep 2017 15:40:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7707FC04B318 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F78C6FDCF; Fri, 22 Sep 2017 15:40:02 +0000 (UTC) Subject: Re: Obsolete/remove Solaris < 10 [was: Re: Fix gdb 8.1 Solaris compilation] To: Rainer Orth References: <47bb2956-5654-0ce3-26dd-9f6b76ff6e08@redhat.com> Cc: Andreas Schwab , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 22 Sep 2017 15:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00680.txt.bz2 On 09/22/2017 03:44 PM, Rainer Orth wrote: >> On 09/21/2017 03:30 PM, Rainer Orth wrote: > >> all these years stepped forward, I think we should be able to just drop >> it. I think you've proposed this in the past, even. I very > > Indeed: I found a line or two of notes about it. Must have been in the > context of removing support for unstructured /proc in procfs.c and > friends. I've dusted off and completed that patch as well... Yay, looking forward to that. :-) >> much doubt anyone would step forward this time. > > Indeed. I've opened a tracking PR gdb/22185 and produced a first patch. > It will need a bit more testing (especially on Linux which also uses > proc-service.c), but it's basically straightforward. Eh, the Solaris port doesn't actually use proc-service.c. The Solaris proc-service implementation is directly in sol-thread.c. I think proc-service.c was originally based on sol-thread.c, maybe aiming at sharing at some point, and that's where it got the PROC_SERVICE_IS_OLD handling from. The patch looks good to me. I mildly wonder if the adding of sol-thread.o could move from gdb/configure.ac to gdb/configure.nat. Thanks, Pedro Alves