Oh dear. I regret to inform you that commit beadd3e84ed8e652015f07eb4734a6d3b17e79cb might be unfortunate

Oh dear. I regret to inform you that commit beadd3e84ed8e652015f07eb4734a6d3b17e79cb might be unfortunate

[gdb-buildbot]

My lords, ladies, gentlemen, members of the public.

It is a matter of great regret and sadness to inform you that commit:

	dwarf2read: replace gdb::optional<bool> with enum
	beadd3e84ed8e652015f07eb4734a6d3b17e79cb

might have made GDB unwell.  Since I am just your Butler BuildBot,
I kindly ask that a human superior officer double-check this.

Please note that if you are reading this message on gdb-patches, there might
be other builders broken.

You can find more details about the unfortunate breakage in the next messages.

Cheers,

Your GDB BuildBot.

Breakage on builder NetBSD-x86_64-m64, revision beadd3e84ed8e652015f07eb4734a6d3b17e79cb

[gdb-buildbot]

Unfortunately it seems that there is a breakage on GDB.

Commit title: 'dwarf2read: replace gdb::optional<bool> with enum'
Revision: beadd3e84ed8e652015f07eb4734a6d3b17e79cb

You can find more details below:

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+


+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    break-catch-syscall.o
  CXX    break-catch-throw.o
  CXX    breakpoint.o
  CXX    btrace.o
  CXX    build-id.o
  CXX    buildsym-legacy.o
  CXX    buildsym.o
  YACC   c-exp.c
/data/motusgdb/gdbosci/netbsd-x86_64/build/gdb/../../binutils-gdb/gdb/c-exp.y: warning: 42 shift/reduce conflicts [-Wconflicts-sr]
/data/motusgdb/gdbosci/netbsd-x86_64/build/gdb/../../binutils-gdb/gdb/c-exp.y: warning: 53 reduce/reduce conflicts [-Wconflicts-rr]
  CXX    c-exp.o
  CXX    c-lang.o
  CXX    c-typeprint.o
  CXX    c-valprint.o
  CXX    c-varobj.o
  CXX    charset.o
  CXX    cli-out.o
  CXX    cli/cli-cmds.o
  CXX    cli/cli-decode.o
  CXX    cli/cli-dump.o
  CXX    cli/cli-interp.o
  CXX    cli/cli-logging.o
  CXX    cli/cli-option.o
  CXX    cli/cli-script.o
  CXX    cli/cli-setshow.o
  CXX    cli/cli-style.o
  CXX    cli/cli-utils.o
  CXX    coff-pe-read.o
  CXX    coffread.o
  CXX    compile/compile-c-support.o
  CXX    compile/compile-c-symbols.o
  CXX    compile/compile-c-types.o
  CXX    compile/compile-cplus-symbols.o
  CXX    compile/compile-cplus-types.o
  CXX    compile/compile-loc2c.o
  CXX    compile/compile-object-load.o
  CXX    compile/compile-object-run.o
  CXX    compile/compile.o
  CXX    complaints.o
  CXX    completer.o
  CXX    continuations.o
  CXX    copying.o
  CXX    corefile.o
  CXX    corelow.o
  CXX    cp-abi.o
  YACC   cp-name-parser.c
  CXX    cp-name-parser.o
  CXX    cp-namespace.o
  CXX    cp-support.o
  CXX    cp-valprint.o
  CXX    ctf.o
  YACC   d-exp.c
  CXX    d-exp.o
  CXX    d-lang.o
  CXX    d-namespace.o
  CXX    d-valprint.o
  CXX    dbxread.o
  CXX    dcache.o
  CXX    debug.o
  CXX    demangle.o
  CXX    dictionary.o
  CXX    disasm-selftests.o
  CXX    disasm.o
  CXX    dtrace-probe.o
  CXX    dummy-frame.o
  CXX    dwarf-index-cache.o
  CXX    dwarf-index-common.o
  CXX    dwarf-index-write.o
  CXX    dwarf2-frame-tailcall.o
  CXX    dwarf2-frame.o
  CXX    dwarf2expr.o
  CXX    dwarf2loc.o
  CXX    dwarf2read.o
../../binutils-gdb/gdb/dwarf2read.c: In member function 'dwarf2_per_cu_data* dw2_debug_names_iterator::next()':
../../binutils-gdb/gdb/dwarf2read.c:5850:22: error: 'symbol_linkage' is not a class, namespace, or enumeration
   } symbol_linkage = symbol_linkage::unknown;
                      ^
../../binutils-gdb/gdb/dwarf2read.c:5902:21: error: 'symbol_linkage' is not a class, namespace, or enumeration
    symbol_linkage = symbol_linkage::static_;
                     ^
../../binutils-gdb/gdb/dwarf2read.c:5907:21: error: 'symbol_linkage' is not a class, namespace, or enumeration
    symbol_linkage = symbol_linkage::extern_;
                     ^
../../binutils-gdb/gdb/dwarf2read.c:5917:25: error: 'symbol_linkage' is not a class, namespace, or enumeration
   if (symbol_linkage != symbol_linkage::unknown && m_block_index.has_value ())
                         ^
../../binutils-gdb/gdb/dwarf2read.c:5920:50: error: 'symbol_linkage' is not a class, namespace, or enumeration
  const bool symbol_is_static = symbol_linkage == symbol_linkage::static_;
                                                  ^
Makefile:1634: recipe for target 'dwarf2read.o' failed
gmake[2]: Leaving directory '/data/motusgdb/gdbosci/netbsd-x86_64/build/gdb'
gmake[2]: *** [dwarf2read.o] Error 1
Makefile:9228: recipe for target 'all-gdb' failed
gmake[1]: *** [all-gdb] Error 2
gmake[1]: Leaving directory '/data/motusgdb/gdbosci/netbsd-x86_64/build'
Makefile:850: recipe for target 'all' failed
gmake: *** [all] Error 2
program finished with exit code 2
elapsedTime=333.260051

Re: Breakage on builder NetBSD-x86_64-m64, revision beadd3e84ed8e652015f07eb4734a6d3b17e79cb

[Simon Marchi]

On 2019-08-25 6:41 p.m., gdb-buildbot@sergiodj.net wrote:
> Unfortunately it seems that there is a breakage on GDB.
> 
> Commit title: 'dwarf2read: replace gdb::optional<bool> with enum'
> Revision: beadd3e84ed8e652015f07eb4734a6d3b17e79cb
> 
> You can find more details below:

I pushed the following patch to try to fix this.


From 23c13d42999cdcf9d224f089891fd3f3c8bdc6aa Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@efficios.com>
Date: Sun, 25 Aug 2019 21:30:02 -0400
Subject: [PATCH] dwarf2read: fix compilation issue with gcc 4.8
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

gcc 4.8 (and probably other versions too) doesn't like that the local
variable symbol_linkage has the same name as the enum class defined in
the same context:

      CXX    dwarf2read.o
    /home/smarchi/src/binutils-gdb/gdb/dwarf2read.c: In member function ‘dwarf2_per_cu_data* dw2_debug_names_iterator::next()’:
    /home/smarchi/src/binutils-gdb/gdb/dwarf2read.c:5850:22: error: ‘symbol_linkage’ is not a class, namespace, or enumeration
       } symbol_linkage = symbol_linkage::unknown;
                      ^

Rename the local variable to avoid this.

This problem was originally reported with the Netbsd builder on the
buildbot, which uses gcc 5.5, I believe.  I am not able to test it on
that builder right now, but chances are that the fix will work there
too.

gdb/ChangeLog:

	* dwarf2read.c (dw2_debug_names_iterator::next): Rename local
	variable symbol_linkage to symbol_linkage_.
---
 gdb/ChangeLog    |  5 +++++
 gdb/dwarf2read.c | 11 ++++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5f64ca6d4a94..d4b1e539c392 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
+
+	* dwarf2read.c (dw2_debug_names_iterator::next): Rename local
+	variable symbol_linkage to symbol_linkage_.
+
 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>

 	* dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index a0b989fd0c2e..af4af195a092 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -5847,7 +5847,7 @@ dw2_debug_names_iterator::next ()
     unknown,
     static_,
     extern_,
-  } symbol_linkage = symbol_linkage::unknown;
+  } symbol_linkage_ = symbol_linkage::unknown;
   dwarf2_per_cu_data *per_cu = NULL;
   for (const mapped_debug_names::index_val::attr &attr : indexval.attr_vec)
     {
@@ -5899,12 +5899,12 @@ dw2_debug_names_iterator::next ()
 	case DW_IDX_GNU_internal:
 	  if (!m_map.augmentation_is_gdb)
 	    break;
-	  symbol_linkage = symbol_linkage::static_;
+	  symbol_linkage_ = symbol_linkage::static_;
 	  break;
 	case DW_IDX_GNU_external:
 	  if (!m_map.augmentation_is_gdb)
 	    break;
-	  symbol_linkage = symbol_linkage::extern_;
+	  symbol_linkage_ = symbol_linkage::extern_;
 	  break;
 	}
     }
@@ -5914,10 +5914,11 @@ dw2_debug_names_iterator::next ()
     goto again;

   /* Check static vs global.  */
-  if (symbol_linkage != symbol_linkage::unknown && m_block_index.has_value ())
+  if (symbol_linkage_ != symbol_linkage::unknown && m_block_index.has_value ())
     {
 	const bool want_static = *m_block_index == STATIC_BLOCK;
-	const bool symbol_is_static = symbol_linkage == symbol_linkage::static_;
+	const bool symbol_is_static =
+	  symbol_linkage_ == symbol_linkage::static_;
 	if (want_static != symbol_is_static)
 	  goto again;
     }
-- 
2.23.0