Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [pushed] Fix typo in sim/ppc/std-config.h
@ 2026-04-21 14:47 Tom Tromey
  2026-04-21 15:08 ` Simon Marchi
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2026-04-21 14:47 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

A user noticed a typo in a preprocessor condition in
sim/ppc/std-config.h.  This fixes it.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34087
---
 sim/ppc/std-config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sim/ppc/std-config.h b/sim/ppc/std-config.h
index d1cd981fb62..f544285d493 100644
--- a/sim/ppc/std-config.h
+++ b/sim/ppc/std-config.h
@@ -584,7 +584,7 @@ extern int current_stdio;
 /* idecode acts as the hub of the system, everything else is imported
    into this file */
 
-#ifndef IDECOCE_INLINE
+#ifndef IDECODE_INLINE
 #define IDECODE_INLINE			INLINE_LOCALS
 #endif
 

base-commit: a2dd0aa39f9f95da718b375662b8c62f4d8ce833
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pushed] Fix typo in sim/ppc/std-config.h
  2026-04-21 14:47 [pushed] Fix typo in sim/ppc/std-config.h Tom Tromey
@ 2026-04-21 15:08 ` Simon Marchi
  2026-04-21 19:43   ` Tom Tromey
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2026-04-21 15:08 UTC (permalink / raw)
  To: Tom Tromey, gdb-patches

On 4/21/26 10:47 AM, Tom Tromey wrote:
> A user noticed a typo in a preprocessor condition in
> sim/ppc/std-config.h.  This fixes it.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34087
> ---
>  sim/ppc/std-config.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sim/ppc/std-config.h b/sim/ppc/std-config.h
> index d1cd981fb62..f544285d493 100644
> --- a/sim/ppc/std-config.h
> +++ b/sim/ppc/std-config.h
> @@ -584,7 +584,7 @@ extern int current_stdio;
>  /* idecode acts as the hub of the system, everything else is imported
>     into this file */
>  
> -#ifndef IDECOCE_INLINE
> +#ifndef IDECODE_INLINE
>  #define IDECODE_INLINE			INLINE_LOCALS
>  #endif
>  
> 
> base-commit: a2dd0aa39f9f95da718b375662b8c62f4d8ce833
> -- 
> 2.53.0
> 

It would be nice to use the gdb include guard checker for the sim
directory, if the sim maintainers are interested.

Simon

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pushed] Fix typo in sim/ppc/std-config.h
  2026-04-21 15:08 ` Simon Marchi
@ 2026-04-21 19:43   ` Tom Tromey
  0 siblings, 0 replies; 3+ messages in thread
From: Tom Tromey @ 2026-04-21 19:43 UTC (permalink / raw)
  To: Simon Marchi; +Cc: Tom Tromey, gdb-patches

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> -#ifndef IDECOCE_INLINE
>> +#ifndef IDECODE_INLINE
>> #define IDECODE_INLINE			INLINE_LOCALS
>> #endif


Simon> It would be nice to use the gdb include guard checker for the sim
Simon> directory, if the sim maintainers are interested.

Yeah, though despite what the bug says, this is not actually an include
guard and wouldn't be caught by the checker.

Tom

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-21 19:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-21 14:47 [pushed] Fix typo in sim/ppc/std-config.h Tom Tromey
2026-04-21 15:08 ` Simon Marchi
2026-04-21 19:43   ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox