Re: [patch] gdb/testsuite: Adjust command completion output when TUI is disabled

[Pedro Alves <palves@redhat.com>]

On 6/23/20 7:27 AM, Sandra Loosemore wrote:
> This is another almost-obvious testsuite fix, for one of the command-completion tests that was failing due to an incorrect assumption that TUI commands are always present.  OK to commit, or is this just a poorly-designed testcase that we should rewrite some other way instead?

With my "I wrote that" hat on, I don't see any other way to write that
test.  We want to check that TAB on an empty input line completes
all commands.  "+" only happens to be the one that sorts second in
the all-commands set.  The only way that I think we could get rid of the
TUI vs non-TUI difference is if we limit the number of completions to 1
instead of 2.  Then only "!" shows up.  But the "1 completion match only"
case makes GDB behave differently (it completes immediately), so I don't
think that's a good idea.

Thus, I think your patch is OK.

Thanks,
Pedro Alves