From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id BD8453939C35 for ; Tue, 23 Jun 2020 12:07:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BD8453939C35 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-ib2DU2PZM9K5dqQzcSUPdA-1; Tue, 23 Jun 2020 08:06:59 -0400 X-MC-Unique: ib2DU2PZM9K5dqQzcSUPdA-1 Received: by mail-wm1-f72.google.com with SMTP id t127so3984957wmg.0 for ; Tue, 23 Jun 2020 05:06:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i+jVsrLqqQuCvEHvyBqKaVn73aa+a4q/UfF9mvBGjnI=; b=uHlm3VDgeJ2HLFzTQxGf2A5zU1tXMuYfbP5zMOyXz8Bin9jHO2T0uDlmHkGub1vQFk kJ5Bgu/oNzOHs1NvTYVtESAhIqAkOjczmsmtBFFCGOw3KLHQWwo+KS3IrGNDb+nTjppC 1JPAS/NcQP+0lvI0b4LNrtv3cvDfOsOYREhX86DsFe3EfqCw2UfEu4d8QiHSJlOA4JE+ UZhjIYRZWBCpIYWmfIdWk/JAZYy/zKwHFpFSBVSjUt3s07vGawsLI06fRVIaFxI36XR0 pxXO6IUWEpIUDoXSxfPrIAE2spmep7r3SNSuaWDaETkgGW39BIf0h/gfIIx0LtZzz3le qwiQ== X-Gm-Message-State: AOAM533quJY4id13iIkorngKeAgz2XzTuzPr8fQYpG8i+HmVcyL97GaP APq6dKVnIjf8lVW02ItSTUl2nLcUlT2+ErBSUHUTuLEP3SZe3cK2go50YIUTGk5xki5oFqKezfP CjA1CT3jKd6Bvp+hn7dHoGw== X-Received: by 2002:a5d:688c:: with SMTP id h12mr13533980wru.212.1592914018547; Tue, 23 Jun 2020 05:06:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxS3mbu/ZAamdp4qGhNRIVzZ7Ttb8Vzb0dariT8sSAyK0d4NKcwfpKwr54yXK50MlKqeFm0Ww== X-Received: by 2002:a5d:688c:: with SMTP id h12mr13533966wru.212.1592914018312; Tue, 23 Jun 2020 05:06:58 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id a16sm21490675wrx.8.2020.06.23.05.06.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2020 05:06:57 -0700 (PDT) Subject: Re: [patch] gdb/testsuite: Adjust command completion output when TUI is disabled To: Sandra Loosemore , "gdb-patches@sourceware.org" References: <73d8a79e-8dea-cbbb-a29f-925eda3230dd@codesourcery.com> From: Pedro Alves Message-ID: Date: Tue, 23 Jun 2020 13:06:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <73d8a79e-8dea-cbbb-a29f-925eda3230dd@codesourcery.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2020 12:07:03 -0000 On 6/23/20 7:27 AM, Sandra Loosemore wrote: > This is another almost-obvious testsuite fix, for one of the command-completion tests that was failing due to an incorrect assumption that TUI commands are always present.  OK to commit, or is this just a poorly-designed testcase that we should rewrite some other way instead? With my "I wrote that" hat on, I don't see any other way to write that test. We want to check that TAB on an empty input line completes all commands. "+" only happens to be the one that sorts second in the all-commands set. The only way that I think we could get rid of the TUI vs non-TUI difference is if we limit the number of completions to 1 instead of 2. Then only "!" shows up. But the "1 completion match only" case makes GDB behave differently (it completes immediately), so I don't think that's a good idea. Thus, I think your patch is OK. Thanks, Pedro Alves