From: John Baldwin <jhb@FreeBSD.org>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/5] Add support for 'info proc files' on FreeBSD core dumps.
Date: Thu, 13 Sep 2018 18:42:00 -0000 [thread overview]
Message-ID: <ba1e09c5-7b97-fbe2-8cd5-11d66c731006@FreeBSD.org> (raw)
In-Reply-To: <878t45qvuo.fsf@tromey.com>
On 9/13/18 8:07 AM, Tom Tromey wrote:
>>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
>
> John> That comment is in the structure 'struct kinfo_ofile' which is for
> John> an older format of this structure used in FreeBSD 7.0 kernels. 7.1
> John> and later kernels use the 'struct kinfo_file' structure which has a
> John> fixed layout (and includes an explicit kf_pad0 padding field). FreeBSD
> John> didn't add the NT_PROCSTAT_FILES note to process core dumps until FreeBSD
> John> 10.0 (also merged to 9.2), so process cores have only ever included the
> John> newer format with a fixed layout.
>
> John> If it is helpful I could add a comment. I think I redid the same
> John> archaeology when adding the initial 'info proc' core dump bits for
> John> FreeBSD. :)
>
> I think a comment sounds helpful for future developers.
I added one in the V2 series.
--
John Baldwin
                                                                           Â
next prev parent reply other threads:[~2018-09-13 18:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 0:38 [PATCH 0/5] Add a new 'info proc files' command John Baldwin
2018-09-08 0:38 ` [PATCH 3/5] Add support for 'info proc files' on FreeBSD core dumps John Baldwin
2018-09-08 22:54 ` Simon Marchi
2018-09-10 19:37 ` John Baldwin
2018-09-13 15:08 ` Tom Tromey
2018-09-13 18:42 ` John Baldwin [this message]
2018-09-08 0:38 ` [PATCH 1/5] Use KF_PATH to verify the size of a struct kinfo_file John Baldwin
2018-09-08 22:25 ` Simon Marchi
2018-09-08 0:38 ` [PATCH 2/5] Add a new 'info proc files' subcommand of 'info proc' John Baldwin
2018-09-08 6:49 ` Eli Zaretskii
2018-09-08 22:31 ` Simon Marchi
2018-09-09 5:23 ` Eli Zaretskii
2018-09-10 18:43 ` John Baldwin
2018-09-10 19:11 ` Eli Zaretskii
2018-09-08 22:32 ` Simon Marchi
2018-09-08 0:46 ` [PATCH 4/5] Support 'info proc files' on live FreeBSD processes John Baldwin
2018-09-08 23:01 ` Simon Marchi
2018-09-10 18:30 ` John Baldwin
2018-09-10 19:03 ` Simon Marchi
2018-09-12 22:38 ` John Baldwin
2018-09-08 0:46 ` [PATCH 5/5] Document the 'info proc files' command John Baldwin
2018-09-08 7:01 ` Eli Zaretskii
2018-09-10 18:43 ` John Baldwin
2018-09-10 19:13 ` Eli Zaretskii
2018-09-10 18:52 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba1e09c5-7b97-fbe2-8cd5-11d66c731006@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox