From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51431 invoked by alias); 13 Sep 2018 18:42:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51229 invoked by uid 89); 13 Sep 2018 18:42:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Sep 2018 18:42:02 +0000 Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 0FBED10B4CE; Thu, 13 Sep 2018 14:41:59 -0400 (EDT) Subject: Re: [PATCH 3/5] Add support for 'info proc files' on FreeBSD core dumps. To: Tom Tromey References: <20180908003659.37482-1-jhb@FreeBSD.org> <20180908003659.37482-4-jhb@FreeBSD.org> <26938c44-7bab-3951-ff2f-d0567d3aee39@ericsson.com> <878t45qvuo.fsf@tromey.com> Cc: Simon Marchi , GDB Patches From: John Baldwin Message-ID: Date: Thu, 13 Sep 2018 18:42:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <878t45qvuo.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00436.txt.bz2 On 9/13/18 8:07 AM, Tom Tromey wrote: >>>>>> "John" == John Baldwin writes: > > John> That comment is in the structure 'struct kinfo_ofile' which is for > John> an older format of this structure used in FreeBSD 7.0 kernels. 7.1 > John> and later kernels use the 'struct kinfo_file' structure which has a > John> fixed layout (and includes an explicit kf_pad0 padding field). FreeBSD > John> didn't add the NT_PROCSTAT_FILES note to process core dumps until FreeBSD > John> 10.0 (also merged to 9.2), so process cores have only ever included the > John> newer format with a fixed layout. > > John> If it is helpful I could add a comment. I think I redid the same > John> archaeology when adding the initial 'info proc' core dump bits for > John> FreeBSD. :) > > I think a comment sounds helpful for future developers. I added one in the V2 series. -- John Baldwin                                                                            Â