Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Eli Zaretskii <eliz@gnu.org>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Subtle problems with "info sharedlibrary" on MS-Windows
Date: Sat, 10 Apr 2021 19:11:15 -0400	[thread overview]
Message-ID: <b8dbbf9e-6124-ab40-9fc8-85e6f4e6354e@polymtl.ca> (raw)
In-Reply-To: <91c6b291-f9f3-0ee9-1ef1-31ba6bb65326@polymtl.ca>

On 2021-04-10 6:56 p.m., Simon Marchi via Gdb-patches wrote:
> 
> 
> On 2021-04-10 2:07 p.m., Eli Zaretskii via Gdb-patches wrote:
>>> From: Tom Tromey <tom@tromey.com>
>>> Cc: ssbssa@yahoo.de,  Eli Zaretskii <eliz@gnu.org>
>>> Date: Sat, 10 Apr 2021 09:03:26 -0600
>>>
>>> I suppose a patch similar to this is needed for gdbserver as well?
>>
>> Is the below okay?
>>
>> --- gdbserver/win32-low.cc~	2021-03-25 03:47:10.000000000 +0200
>> +++ gdbserver/win32-low.cc	2021-04-10 21:05:48.677425000 +0300
>> @@ -1165,11 +1165,13 @@ load_psapi (void)
>>  
>>  #ifndef _WIN32_WCE
> 
> I see that this patch deals with _WIN32_WCE.  We removed support for
> WinCE in 84b300de3666 ("gdbserver: remove support for ARM/WinCE").  It
> looks like I failed to remove the WinCE-related core from win32-low.cc
> (I guess I didn't know about the _WIN32_WCE macro then).  Would you mind
> if we first removed that unncecessary code first?  That would make your
> patch simpler.
> 
> Simon

I sent a patch doing that here:

https://sourceware.org/pipermail/gdb-patches/2021-April/177658.html

Simon

  reply	other threads:[~2021-04-10 23:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 12:36 Eli Zaretskii via Gdb-patches
2021-03-10 16:30 ` Hannes Domani via Gdb-patches
2021-03-10 16:51   ` Eli Zaretskii via Gdb-patches
2021-03-10 17:35     ` Hannes Domani via Gdb-patches
2021-04-05 17:51       ` Eli Zaretskii via Gdb-patches
2021-04-06 13:16         ` Eli Zaretskii via Gdb-patches
2021-04-07 21:18           ` Simon Marchi via Gdb-patches
2021-04-08  7:06             ` Eli Zaretskii via Gdb-patches
2021-04-08 13:57               ` Simon Marchi via Gdb-patches
2021-04-10  8:46                 ` Eli Zaretskii via Gdb-patches
2021-04-10 15:03           ` Tom Tromey
2021-04-10 18:07             ` Eli Zaretskii via Gdb-patches
2021-04-10 22:56               ` Simon Marchi via Gdb-patches
2021-04-10 23:11                 ` Simon Marchi via Gdb-patches [this message]
2021-04-11  7:10                 ` Eli Zaretskii via Gdb-patches
2021-04-11 12:27                   ` Simon Marchi via Gdb-patches
2021-04-11 18:43                     ` Eli Zaretskii via Gdb-patches
2021-04-12 19:03                       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8dbbf9e-6124-ab40-9fc8-85e6f4e6354e@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox