From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] Use a distinguishing name for minidebug objfile
Date: Tue, 18 Apr 2017 17:42:00 -0000 [thread overview]
Message-ID: <b8882bfa-52e4-4df0-5061-0eb12cb01a61@redhat.com> (raw)
In-Reply-To: <20170413041504.14435-2-tom@tromey.com>
On 04/13/2017 05:15 AM, Tom Tromey wrote:
> One part of PR cli/19951 is that the mini debug info objfile reuses the
> name of the main objfile from which it comes. This can be seen because
> gdb claims to be reading symbols from the same file two times, like:
>
> Reading symbols from /bin/gdb...Reading symbols from /bin/gdb...(no debugging symbols found)...done.
>
> I think this would be less confusing if the minidebug objfile were given
> a different name. That is what this patch implements. It also arranges
> for the minidebug objfile to be marked OBJF_NOT_FILENAME.
Could you update the commit log to also show how things look
after the patch? I could guess it after staring at the patch for
a bit, but it'd be nice to be explicit.
Otherwise LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-04-18 17:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 4:17 [RFA 0/2] Fix PR cli/19551 Tom Tromey
2017-04-13 4:17 ` [RFA 2/2] PR cli/19551 - change formatting of "Reading symbols" messages Tom Tromey
2017-04-18 17:43 ` Pedro Alves
2017-04-18 17:44 ` Pedro Alves
2017-04-20 0:11 ` Tom Tromey
2017-04-27 21:40 ` Simon Marchi
2017-04-27 23:16 ` Tom Tromey
2017-04-27 23:53 ` Simon Marchi
2017-05-29 17:24 ` Tom Tromey
2017-04-13 4:44 ` [RFA 1/2] Use a distinguishing name for minidebug objfile Tom Tromey
2017-04-18 17:42 ` Pedro Alves [this message]
2017-04-19 3:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8882bfa-52e4-4df0-5061-0eb12cb01a61@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox