From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9537 invoked by alias); 18 Apr 2017 17:42:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9490 invoked by uid 89); 18 Apr 2017 17:42:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=itd, HTo:U*tom, claims X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 17:42:33 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 943C28124F; Tue, 18 Apr 2017 17:42:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 943C28124F Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 943C28124F Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E5DC817CF3; Tue, 18 Apr 2017 17:42:32 +0000 (UTC) Subject: Re: [RFA 1/2] Use a distinguishing name for minidebug objfile To: Tom Tromey , gdb-patches@sourceware.org References: <20170413041504.14435-1-tom@tromey.com> <20170413041504.14435-2-tom@tromey.com> From: Pedro Alves Message-ID: Date: Tue, 18 Apr 2017 17:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170413041504.14435-2-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00517.txt.bz2 On 04/13/2017 05:15 AM, Tom Tromey wrote: > One part of PR cli/19951 is that the mini debug info objfile reuses the > name of the main objfile from which it comes. This can be seen because > gdb claims to be reading symbols from the same file two times, like: > > Reading symbols from /bin/gdb...Reading symbols from /bin/gdb...(no debugging symbols found)...done. > > I think this would be less confusing if the minidebug objfile were given > a different name. That is what this patch implements. It also arranges > for the minidebug objfile to be marked OBJF_NOT_FILENAME. Could you update the commit log to also show how things look after the patch? I could guess it after staring at the patch for a bit, but it'd be nice to be explicit. Otherwise LGTM. Thanks, Pedro Alves