From: Simon Marchi <simark@simark.ca>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Have 'thread|frame apply' style their output.
Date: Sat, 27 Apr 2019 19:19:00 -0000 [thread overview]
Message-ID: <b830d155-7dff-c814-4f38-0ec86b1e262d@simark.ca> (raw)
In-Reply-To: <1556368938.22002.19.camel@skynet.be>
On 2019-04-27 8:42 a.m., Philippe Waroquiers wrote:
> Thanks for the review. Pushed after fixing (for the "const?" comment,
> I have added an explanation to clarify).
>
> Philippe
Hi Philippe,
There is one more spot to update, which you'll find if you build with --with-guile:
CXX guile/guile.o
/home/simark/src/binutils-gdb/gdb/guile/guile.c: In lambda function:
/home/simark/src/binutils-gdb/gdb/guile/guile.c:310:62: error: too few arguments to function âstd::__cxx11::string execute_command_to_string(const char*, int, bool)â
to_string_res = execute_command_to_string (command, from_tty);
^
In file included from /home/simark/src/binutils-gdb/gdb/guile/guile.c:29:
/home/simark/src/binutils-gdb/gdb/gdbcmd.h:140:20: note: declared here
extern std::string execute_command_to_string (const char *p, int from_tty,
^~~~~~~~~~~~~~~~~~~~~~~~~
I presume you'll want to pass false in this case, since it's specifically meant to
send the output to a string, where we don't want styling?
Simon
next prev parent reply other threads:[~2019-04-27 19:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 22:59 Philippe Waroquiers
2019-03-22 5:31 ` PING " Philippe Waroquiers
2019-03-29 8:01 ` PING^2 " Philippe Waroquiers
2019-04-18 4:12 ` PING^3 " Philippe Waroquiers
2019-04-25 15:46 ` Tom Tromey
2019-04-27 12:42 ` Philippe Waroquiers
2019-04-27 19:19 ` Simon Marchi [this message]
2019-04-28 5:19 ` Philippe Waroquiers
2019-04-28 14:59 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b830d155-7dff-c814-4f38-0ec86b1e262d@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox