From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46907 invoked by alias); 27 Apr 2019 19:19:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46894 invoked by uid 89); 27 Apr 2019 19:19:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=spot, HContent-Transfer-Encoding:8bit X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 27 Apr 2019 19:19:46 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3B40C1E180; Sat, 27 Apr 2019 15:19:44 -0400 (EDT) Subject: Re: [RFA] Have 'thread|frame apply' style their output. To: Philippe Waroquiers , Tom Tromey Cc: gdb-patches@sourceware.org References: <20190309225932.14568-1-philippe.waroquiers@skynet.be> <874l6mcckt.fsf@tromey.com> <1556368938.22002.19.camel@skynet.be> From: Simon Marchi Message-ID: Date: Sat, 27 Apr 2019 19:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1556368938.22002.19.camel@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-04/txt/msg00607.txt.bz2 On 2019-04-27 8:42 a.m., Philippe Waroquiers wrote: > Thanks for the review. Pushed after fixing (for the "const?" comment, > I have added an explanation to clarify). > > Philippe Hi Philippe, There is one more spot to update, which you'll find if you build with --with-guile: CXX guile/guile.o /home/simark/src/binutils-gdb/gdb/guile/guile.c: In lambda function: /home/simark/src/binutils-gdb/gdb/guile/guile.c:310:62: error: too few arguments to function ‘std::__cxx11::string execute_command_to_string(const char*, int, bool)’ to_string_res = execute_command_to_string (command, from_tty); ^ In file included from /home/simark/src/binutils-gdb/gdb/guile/guile.c:29: /home/simark/src/binutils-gdb/gdb/gdbcmd.h:140:20: note: declared here extern std::string execute_command_to_string (const char *p, int from_tty, ^~~~~~~~~~~~~~~~~~~~~~~~~ I presume you'll want to pass false in this case, since it's specifically meant to send the output to a string, where we don't want styling? Simon