From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Shahab Vahedi <shahab.vahedi@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/5] gdb: change jit_debug to a bool
Date: Wed, 13 Jan 2021 10:49:54 -0500 [thread overview]
Message-ID: <b71a6a37-9fa2-92f3-6807-575a566fc967@polymtl.ca> (raw)
In-Reply-To: <X/8Ef9cMI536I+X3@gmail.com>
On 2021-01-13 9:32 a.m., Shahab Vahedi wrote:
> Hi Simon,
>
> This patch looks fine to me with a minor comment.
>
> Simon Marchi wrote:
>> static void
>> show_jit_debug (struct ui_file *file, int from_tty,
>> @@ -1251,13 +1251,13 @@ _initialize_jit ()
>> {
>> jit_reader_dir = relocate_gdb_directory (JIT_READER_DIR,
>> JIT_READER_DIR_RELOCATABLE);
>> - add_setshow_zuinteger_cmd ("jit", class_maintenance, &jit_debug,
>> - _("Set JIT debugging."),
>> - _("Show JIT debugging."),
>> - _("When non-zero, JIT debugging is enabled."),
>> - NULL,
>> - show_jit_debug,
>> - &setdebuglist, &showdebuglist);
>> + add_setshow_boolean_cmd ("jit", class_maintenance, &jit_debug,
>> + _("Set JIT debugging."),
>> + _("Show JIT debugging."),
>> + _("When non-zero, JIT debugging is enabled."),
> "When set, JIT debugging is enabled."
Good point, fixed. I'll push the patch with that fixed, it's probably
not too controversial anyway.
Thanks!
Simon
prev parent reply other threads:[~2021-01-13 15:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 4:28 Simon Marchi via Gdb-patches
2021-01-09 4:28 ` [PATCH 2/5] gdb: convert jit to new-style debug macros Simon Marchi via Gdb-patches
2021-01-11 21:18 ` Tom Tromey
2021-01-11 21:20 ` Simon Marchi via Gdb-patches
2021-01-09 4:28 ` [PATCH 3/5] gdb: convert aarch64 " Simon Marchi via Gdb-patches
2021-01-09 4:31 ` Simon Marchi via Gdb-patches
2021-01-11 13:18 ` Luis Machado via Gdb-patches
2021-01-11 21:30 ` Simon Marchi via Gdb-patches
2021-01-11 21:50 ` Luis Machado via Gdb-patches
2021-01-11 21:54 ` Simon Marchi via Gdb-patches
2021-01-09 4:28 ` [PATCH 4/5] gdb: convert solib-aix " Simon Marchi via Gdb-patches
2021-01-11 21:19 ` Tom Tromey
2021-01-11 21:32 ` Simon Marchi via Gdb-patches
2021-01-09 4:28 ` [PATCH 5/5] gdb: convert arc " Simon Marchi via Gdb-patches
2021-01-09 4:37 ` Simon Marchi via Gdb-patches
2021-01-13 15:35 ` Shahab Vahedi via Gdb-patches
2021-01-09 4:29 ` [PATCH 1/5] gdb: change jit_debug to a bool Simon Marchi via Gdb-patches
2021-01-11 21:17 ` Tom Tromey
2021-01-11 21:19 ` Simon Marchi via Gdb-patches
2021-01-13 14:32 ` Shahab Vahedi via Gdb-patches
2021-01-13 15:49 ` Simon Marchi via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b71a6a37-9fa2-92f3-6807-575a566fc967@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=shahab.vahedi@gmail.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox