From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AJeqBq4W/18LfQAAWB0awg (envelope-from ) for ; Wed, 13 Jan 2021 10:50:06 -0500 Received: by simark.ca (Postfix, from userid 112) id 0E86F1EF80; Wed, 13 Jan 2021 10:50:06 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A15BA1E940 for ; Wed, 13 Jan 2021 10:50:05 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 08969385783D; Wed, 13 Jan 2021 15:50:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08969385783D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610553005; bh=XgfbzxwKyIofShfoVor/fpsUagx6WPa9k1UmYuBRDCI=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xavFRlQeevG1kWUbNzje8wtiFnx+Wdx4nWshUf2D8qyk9dtnfntsExt+ibxHRD2F1 E1X6TZkY+Jyf1nUQqKoINoOg735rMFzwPCMDx7JBEFAZVxCC+BWvEeKa32VAzOfPbJ YsMTSxi+FWQ7rmg1+oANgHXAqTWZ6lL4xRerGwpU= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 23DD7385783D for ; Wed, 13 Jan 2021 15:50:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23DD7385783D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10DFnsAl020991 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jan 2021 10:49:59 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10DFnsAl020991 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B2B061E940; Wed, 13 Jan 2021 10:49:54 -0500 (EST) Subject: Re: [PATCH 1/5] gdb: change jit_debug to a bool To: Shahab Vahedi References: Message-ID: Date: Wed, 13 Jan 2021 10:49:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 13 Jan 2021 15:49:54 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-13 9:32 a.m., Shahab Vahedi wrote: > Hi Simon, > > This patch looks fine to me with a minor comment. > > Simon Marchi wrote: >> static void >> show_jit_debug (struct ui_file *file, int from_tty, >> @@ -1251,13 +1251,13 @@ _initialize_jit () >> { >> jit_reader_dir = relocate_gdb_directory (JIT_READER_DIR, >> JIT_READER_DIR_RELOCATABLE); >> - add_setshow_zuinteger_cmd ("jit", class_maintenance, &jit_debug, >> - _("Set JIT debugging."), >> - _("Show JIT debugging."), >> - _("When non-zero, JIT debugging is enabled."), >> - NULL, >> - show_jit_debug, >> - &setdebuglist, &showdebuglist); >> + add_setshow_boolean_cmd ("jit", class_maintenance, &jit_debug, >> + _("Set JIT debugging."), >> + _("Show JIT debugging."), >> + _("When non-zero, JIT debugging is enabled."), > "When set, JIT debugging is enabled." Good point, fixed. I'll push the patch with that fixed, it's probably not too controversial anyway. Thanks! Simon