Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] [gdb/tui] Expand WDB reference
@ 2026-04-24  8:52 Tom de Vries
  2026-04-24 14:53 ` Tom Tromey
  0 siblings, 1 reply; 3+ messages in thread
From: Tom de Vries @ 2026-04-24  8:52 UTC (permalink / raw)
  To: gdb-patches

In gdb/tui/tui.c I came across:
...
/* General functions for the WDB TUI.
...

Initially I thought this was a WDB->GDB typo, but after searching a bit I
found out that this is a reference to HP Wildebeest, a port of GDB to HP-UX.

Change the comment line to use "General functions for the GDB TUI", and
instead mention it here in a more descriptive form:
...
-   Contributed by Hewlett-Packard Company.
+   Contributed by Hewlett-Packard Company.  Developed as part of HP Wildebeest
+   (WDB), a port of GDB to HP-UX.
...

While we're at it, remove a pointless "This is a sample program for the HP WDB
debugger" note in gdb.base/average.c.
---
 gdb/testsuite/gdb.base/average.c | 2 --
 gdb/tui/tui.c                    | 5 +++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/gdb.base/average.c b/gdb/testsuite/gdb.base/average.c
index b99dcf49629..1dac44590da 100644
--- a/gdb/testsuite/gdb.base/average.c
+++ b/gdb/testsuite/gdb.base/average.c
@@ -1,5 +1,3 @@
-/* This is a sample program for the HP WDB debugger. */
-
 #include <stdio.h>
 #include <stdlib.h>
 
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 5e39eef71c6..35c3b80603d 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -1,8 +1,9 @@
-/* General functions for the WDB TUI.
+/* General functions for the GDB TUI.
 
    Copyright (C) 1998-2026 Free Software Foundation, Inc.
 
-   Contributed by Hewlett-Packard Company.
+   Contributed by Hewlett-Packard Company.  Developed as part of HP Wildebeest
+   (WDB), a port of GDB to HP-UX.
 
    This file is part of GDB.
 

base-commit: 08610a4004a2906a2ae1b4676601a72e3b93c16a
-- 
2.51.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [gdb/tui] Expand WDB reference
  2026-04-24  8:52 [PATCH] [gdb/tui] Expand WDB reference Tom de Vries
@ 2026-04-24 14:53 ` Tom Tromey
  2026-04-26 19:20   ` Tom de Vries
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2026-04-24 14:53 UTC (permalink / raw)
  To: Tom de Vries; +Cc: gdb-patches

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Change the comment line to use "General functions for the GDB TUI", and
Tom> instead mention it here in a more descriptive form:
Tom> ...
Tom> -   Contributed by Hewlett-Packard Company.
Tom> +   Contributed by Hewlett-Packard Company.  Developed as part of HP Wildebeest
Tom> +   (WDB), a port of GDB to HP-UX.
Tom> ...

Tom> While we're at it, remove a pointless "This is a sample program for the HP WDB
Tom> debugger" note in gdb.base/average.c.

Ok.
Approved-By: Tom Tromey <tom@tromey.com>

Tom> +++ b/gdb/testsuite/gdb.base/average.c
Tom> @@ -1,5 +1,3 @@
Tom> -/* This is a sample program for the HP WDB debugger. */
Tom> -

I wonder if this ought to have a GPL header.

Tom

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [gdb/tui] Expand WDB reference
  2026-04-24 14:53 ` Tom Tromey
@ 2026-04-26 19:20   ` Tom de Vries
  0 siblings, 0 replies; 3+ messages in thread
From: Tom de Vries @ 2026-04-26 19:20 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

On 4/24/26 4:53 PM, Tom Tromey wrote:
> Tom> +++ b/gdb/testsuite/gdb.base/average.c
> Tom> @@ -1,5 +1,3 @@
> Tom> -/* This is a sample program for the HP WDB debugger. */
> Tom> -
> 
> I wonder if this ought to have a GPL header.

Yeah.  I've filed a PR ( 
https://sourceware.org/bugzilla/show_bug.cgi?id=34106 ) about adding 
this automatically using a pre-commit hook.

Thanks,
- Tom

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-26 19:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-24  8:52 [PATCH] [gdb/tui] Expand WDB reference Tom de Vries
2026-04-24 14:53 ` Tom Tromey
2026-04-26 19:20   ` Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox