Re: [PATCH v2] gdb/Python: Added ThreadExitedEvent

[Pedro Alves <pedro@palves.net>]

On 2022-04-12 10:03, Simon Farre via Gdb-patches wrote:
>  
> +@item events.thread_exited
> +This is emitted when @value{GDBN} notices a thread has exited.  The event
> +is of type @code{gdb.ThreadExitedEvent}.  This has three attributes:
> +
> +@defvar ThreadExitedEvent.num
> +Global thread number.
> +@end defvar
> +
> +@defvar ThreadExitedEvent.lwp
> +The light weight process ID.
> +@end defvar
> +
> +@defvar ThreadExitedEvent.tid
> +The thread's thread id
> +@end defvar

Do other thread events have these same attributes?  It seems odd to print lwp and tid, but not pid.

But why not a ptid object instead?  InferiorThread has:


~~~
Variable: InferiorThread.ptid
ID of the thread, as assigned by the operating system. This attribute is a tuple containing three integers.
The first is the Process ID (PID); the second is the Lightweight Process ID (LWPID), and the third is the Thread ID (TID). 
Either the LWPID or TID may be 0, which indicates that the operating system does not use that identifier.
~~~

And other events use it too, like:

~~~
 Variable: InferiorCallPreEvent.ptid
 The thread in which the call will be run.

 gdb.InferiorCallPostEvent
 Indicates that a function in the inferior has just been called.

 Variable: InferiorCallPostEvent.ptid
~~~

I think not using ptid requires a strong justification.

But I also think that it might be useful to contrast the attributes included in the Python event to
what MI events include.