Re: [PATCH v2] gdb/Python: Added ThreadExitedEvent

[Simon Farre via Gdb-patches <gdb-patches@sourceware.org>]

Tom> Space before open paren here.
I'll go over and fix white spacing and formatting in the next patch version
(finally getting
the hang of it more or less).

Tom> I'm curious why the event has various attributes of the thread object
Tom> but not a reference to the thread object itself.  That seems a little
Tom> odd.

So my reasoning for this was; since the thread is exiting it is dying, and
from
a Python perspective I thought it proper not to hold on to any resources
that
GDB otherwise would dispose of. I'm open to suggestions for whether or not
this logic is sound. So if we are to return the thread object itself,
I would probably have to change the function from where the event is
emitted, or perhaps
some other change.

It's currently emitted inside `delete_thread_object` which is a function
that is attached
to the observer `gdb::observers::thread_exit` in py-inferior.c. So if we
are to return
a reference to the thread object, the function attached here should
probably be removed
entirely and replaced with just emitting the newly introduced "thread exit
event" (and handle
the de-allocation of the thread object inside the thread exit event type
tp_dealloc function).

Thanks for taking your time to review!
Simon F.