Re: [PATCH 5/5] gdb/amd-dbgapi: disable forward progress requirement in amd_dbgapi_target_breakpoint::check_status

[Simon Marchi <simark@simark.ca>]

>> diff --git a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp
>> new file mode 100644
>> index 000000000000..e97809335569
>> --- /dev/null
>> +++ b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp
>> @@ -0,0 +1,70 @@
> 
> I think you are missing the copyright header for this file.

Done.

>> +#ifdef DEVICE
>> +
>> +#include <hip/hip_runtime.h>
>> +
>> +constexpr unsigned int NUM_BREAKPOINT_HITS = 5;
>> +
>> +static __device__ void
>> +break_here ()
>> +{
>> +  asm ("s_nop 0");
> 
> I don't expect this inline asssembly is necessary.

Ok, will remove it.  Not sure why I added it, I might have had some
trouble with empty functions in the past.

>> diff --git a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.exp b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.exp
>> new file mode 100644
>> index 000000000000..b8d003f37032
>> --- /dev/null
>> +++ b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.exp
>> @@ -0,0 +1,68 @@
>> +# Copyright (C) 2025 Advanced Micro Devices, Inc. All rights reserved.
> 
> The copyright should be to the FSF, not AMD.

Done.

> Given the elements above are fixed,
> 
> Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)

Thanks,

Simon