From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DtwMAyYFR2h2MQcAWB0awg (envelope-from ) for ; Mon, 09 Jun 2025 12:00:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1749484837; bh=VIqon6w08qEvtACk9Bx3gFl3rWSiZZvoMrrPMYw/uEs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cwlPx1iHh/S4nX0qvYZaWZC3woZTIBNcvSNqD3Uu8FEHNp+I246SGM+RCSsd/mphP hx/SukuJFfyQhZShTWjeTllZoo7A3G6+2CIQhpyoLuooolRQxyBsRe56Ry9Pl6rAuF 5spJpU/hKz5B/oYX2uRzFc+MtTnH7O765le/tkTA= Received: by simark.ca (Postfix, from userid 112) id EA7471E11C; Mon, 9 Jun 2025 12:00:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=o2QemAZM; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=RcNCd345; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2EF2E1E0C2 for ; Mon, 9 Jun 2025 12:00:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA4FD382D281 for ; Mon, 9 Jun 2025 16:00:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA4FD382D281 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=o2QemAZM; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=RcNCd345 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 60F73382D475 for ; Mon, 9 Jun 2025 16:00:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 60F73382D475 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 60F73382D475 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749484805; cv=none; b=AndEi8TjyPYxdYFW4hzt2HXe862py9KkpDa/hs2LLp5LFOAdoSWdpqK1fJF0/tAN4gMnI85u8RfGcJBQKhCtMMJzt5L5rI6hfO0Tgi1mz2So7Ew9tw+y1v5WcPpXaJ+JZS13+7toUFJse43D/t9XPuOOeNTTv25xIIzX4TW8cPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749484805; c=relaxed/simple; bh=VIqon6w08qEvtACk9Bx3gFl3rWSiZZvoMrrPMYw/uEs=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=tW/d2/8AuL0iXOdpRfPIKTP2KrUUuWwtTrPMlfJDIe2QV0NnyHxiJ4Ro/jB2T16wTmFOqMRBWkFmYpAb8Z9/K3QTYDzxZEu+iKO1tVq9lT/Af7kL9fbza0siy6B5b/yghw3aswloYeHlx9/kp7ceEKkjGILlTTuq8UB8ZUefXms= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 60F73382D475 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1749484804; bh=VIqon6w08qEvtACk9Bx3gFl3rWSiZZvoMrrPMYw/uEs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=o2QemAZMLH3Jrav8Uj3328E8xALCBzDbivp52aoqruhHLDRai6eQihL1wu+isI1Kf WbkO4HV+jP4sZ+D/TSEkUX/rECX2YTaFMTNuEnv7dr+kCC/RxU2MpoisFh9QEQgDk3 6aHlunWY0PsX7ZKsKs395xXtXB72O+aDpm48vLM8= Received: by simark.ca (Postfix, from userid 112) id F259B1E11C; Mon, 9 Jun 2025 12:00:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1749484800; bh=VIqon6w08qEvtACk9Bx3gFl3rWSiZZvoMrrPMYw/uEs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RcNCd345tp3zyWe7ioHp5uzxMzbYU17OowTZBGlL85RZ5KflDTs4xIFxrVXxm3FUq E4ltQAxTQ+grK07ZkPljxrASlYqXR9Jln0MLOwHwNikgUSxgF/30TgcaXQ202mrjaV abdsA3I4QgbVYeG1NKHlGHTqjlvhOGOwWDARSSdo= Received: from [172.16.0.192] (192-222-132-26.qc.cable.ebox.net [192.222.132.26]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 60B891E0C2; Mon, 9 Jun 2025 12:00:00 -0400 (EDT) Message-ID: Date: Mon, 9 Jun 2025 11:59:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] gdb/amd-dbgapi: disable forward progress requirement in amd_dbgapi_target_breakpoint::check_status To: Lancelot SIX , Simon Marchi Cc: gdb-patches@sourceware.org References: <20250605201657.418206-5-simon.marchi@efficios.com> <666t5msvuyylv2yioapk56jqvjbsxsc7spkf473uu6pfguytfe@hvn54ws4ctzp> Content-Language: fr From: Simon Marchi In-Reply-To: <666t5msvuyylv2yioapk56jqvjbsxsc7spkf473uu6pfguytfe@hvn54ws4ctzp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> diff --git a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp >> new file mode 100644 >> index 000000000000..e97809335569 >> --- /dev/null >> +++ b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.cpp >> @@ -0,0 +1,70 @@ > > I think you are missing the copyright header for this file. Done. >> +#ifdef DEVICE >> + >> +#include >> + >> +constexpr unsigned int NUM_BREAKPOINT_HITS = 5; >> + >> +static __device__ void >> +break_here () >> +{ >> + asm ("s_nop 0"); > > I don't expect this inline asssembly is necessary. Ok, will remove it. Not sure why I added it, I might have had some trouble with empty functions in the past. >> diff --git a/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.exp b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.exp >> new file mode 100644 >> index 000000000000..b8d003f37032 >> --- /dev/null >> +++ b/gdb/testsuite/gdb.rocm/code-object-load-while-breakpoint-hit.exp >> @@ -0,0 +1,68 @@ >> +# Copyright (C) 2025 Advanced Micro Devices, Inc. All rights reserved. > > The copyright should be to the FSF, not AMD. Done. > Given the elements above are fixed, > > Approved-by: Lancelot Six (amdgpu) Thanks, Simon