Re: [PATCH 2/3] x86-bsd-nat: Only define gdb_ptrace when using debug registers.

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-07-26 8:24 p.m., John Baldwin wrote:
> This fixes an unused function warning on OpenBSD which does not
> support PT_GETDBREGS.
> ---
>  gdb/x86-bsd-nat.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/gdb/x86-bsd-nat.c b/gdb/x86-bsd-nat.c
> index 453fc44116..6aac76f182 100644
> --- a/gdb/x86-bsd-nat.c
> +++ b/gdb/x86-bsd-nat.c
> @@ -33,6 +33,14 @@
>  #include "inf-ptrace.h"
>  \f
>  
> +#ifdef PT_GETXSTATE_INFO
> +size_t x86bsd_xsave_len;
> +#endif
> +
> +/* Support for debug registers.  */
> +
> +#ifdef HAVE_PT_GETDBREGS
> +
>  static PTRACE_TYPE_RET
>  gdb_ptrace (PTRACE_TYPE_ARG1 request, ptid_t ptid, PTRACE_TYPE_ARG3 addr)
>  {
> @@ -46,14 +54,6 @@ gdb_ptrace (PTRACE_TYPE_ARG1 request, ptid_t ptid, PTRACE_TYPE_ARG3 addr)
>  #endif
>  }
>  
> -#ifdef PT_GETXSTATE_INFO
> -size_t x86bsd_xsave_len;
> -#endif
> -
> -/* Support for debug registers.  */
> -
> -#ifdef HAVE_PT_GETDBREGS
> -
>  /* Helper macro to access debug register X.  FreeBSD/amd64 and modern
>     versions of FreeBSD/i386 provide this macro in system headers.  Define
>     a local version for systems that do not provide it.  */
> 


OK.

Simon