From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Don't compile x86 debug register support on OpenBSD.
Date: Mon, 26 Jul 2021 21:19:57 -0400 [thread overview]
Message-ID: <46dfd974-d353-9f76-5a42-28ca73760695@polymtl.ca> (raw)
In-Reply-To: <20210727002421.18947-2-jhb@FreeBSD.org>
On 2021-07-26 8:24 p.m., John Baldwin wrote:
> - Change x86bsd_nat_target to only inherit from x86_nat_target if
> PT_GETDBREGS is supported.
>
> - Don't include x86-nat.o and nat/x86-dregs.o for OpenBSD/amd64. They
> were already omitted for OpenBSD/i386.
LGTM, but please add a little bit of info to the commit message, to
explain why this change is needed. You can copy some of that from my
patch's message.
Simon
next prev parent reply other threads:[~2021-07-27 1:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 0:24 [PATCH 0/3] A few fixes to OpenBSD's native target John Baldwin
2021-07-27 0:24 ` [PATCH 1/3] Don't compile x86 debug register support on OpenBSD John Baldwin
2021-07-27 1:19 ` Simon Marchi via Gdb-patches [this message]
2021-07-27 0:24 ` [PATCH 2/3] x86-bsd-nat: Only define gdb_ptrace when using debug registers John Baldwin
2021-07-27 1:20 ` Simon Marchi via Gdb-patches
2021-07-27 0:24 ` [PATCH 3/3] obsd-nat: Various fixes to obsd_nat_target::wait John Baldwin
2021-07-27 1:54 ` Simon Marchi via Gdb-patches
2021-07-27 16:03 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dfd974-d353-9f76-5a42-28ca73760695@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox