Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] C++ify osdata
Date: Fri, 24 Nov 2017 02:58:00 -0000	[thread overview]
Message-ID: <b4725cacea0cebacd2dda4c70e2edb06@polymtl.ca> (raw)
In-Reply-To: <4172ddfc-fb35-e7e6-f168-800eabb62b77@redhat.com>

On 2017-11-23 17:46, Pedro Alves wrote:
> On 11/23/2017 06:39 PM, Simon Marchi wrote:
>> On 2017-11-23 07:54 AM, Pedro Alves wrote:
> 
>>> Isn't this leaking the heap-allocated vectors?
>>> 
>>> Why make it a map of pointers, actually?  Why not:
>>> 
> 
>> Oops, thanks for noticing and for the suggestion.  I don't know what I 
>> was thinking.
>> What about this patch?
> 
> LGTM.
> 
> Thanks,
> Pedro Alves

Thanks, pushed.

Simon


      reply	other threads:[~2017-11-24  2:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-18 23:38 Simon Marchi
2017-11-22 21:15 ` Simon Marchi
2017-11-23 12:54 ` Pedro Alves
2017-11-23 18:39   ` Simon Marchi
2017-11-23 22:46     ` Pedro Alves
2017-11-24  2:58       ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4725cacea0cebacd2dda4c70e2edb06@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox