From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123127 invoked by alias); 24 Nov 2017 02:58:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123114 invoked by uid 89); 24 Nov 2017 02:58:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:452 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Nov 2017 02:58:33 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vAO2wQ9a015357 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Nov 2017 21:58:31 -0500 Received: by simark.ca (Postfix, from userid 112) id 84C821E586; Thu, 23 Nov 2017 21:58:26 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 13C721E030; Thu, 23 Nov 2017 21:58:26 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 24 Nov 2017 02:58:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] C++ify osdata In-Reply-To: <4172ddfc-fb35-e7e6-f168-800eabb62b77@redhat.com> References: <20171118233827.7418-1-simon.marchi@polymtl.ca> <9d0b9473-1fd5-8310-0cde-8233efed58bc@redhat.com> <19f399ce-dfb9-15fd-41ed-2a4576a438f6@ericsson.com> <4172ddfc-fb35-e7e6-f168-800eabb62b77@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 24 Nov 2017 02:58:26 +0000 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00583.txt.bz2 On 2017-11-23 17:46, Pedro Alves wrote: > On 11/23/2017 06:39 PM, Simon Marchi wrote: >> On 2017-11-23 07:54 AM, Pedro Alves wrote: > >>> Isn't this leaking the heap-allocated vectors? >>> >>> Why make it a map of pointers, actually? Why not: >>> > >> Oops, thanks for noticing and for the suggestion. I don't know what I >> was thinking. >> What about this patch? > > LGTM. > > Thanks, > Pedro Alves Thanks, pushed. Simon