From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [commit/obvious] Fix PR 21352: Command tsave does not support -r argument
Date: Wed, 05 Apr 2017 16:49:00 -0000 [thread overview]
Message-ID: <b3704b36-88c2-ac80-c75e-b132a3ff1980@redhat.com> (raw)
In-Reply-To: <87bmsa9517.fsf@redhat.com>
On 04/05/2017 05:45 PM, Sergio Durigan Junior wrote:
> On Wednesday, April 05 2017, Pedro Alves wrote:
>
>> On 04/05/2017 05:31 PM, Sergio Durigan Junior wrote:
>>> This is an obvious fix for PR 21352. The problem is that the argument
>>> parsing loop is not using an "else if" where it should, and therefore
>>> the '-r' option ends up unrecognized by GDB.
>>
>> We have a few tests under gdb.trace/ that exercise "tsave". Would it
>> be easy to augment some to exercise this?
>
> Yes, absolutely. I was thinking about doing that but decided not too.
> Anyway, here's what I checked in.
Thanks, I like the new decision better. :-)
--
Pedro Alves
prev parent reply other threads:[~2017-04-05 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 16:31 Sergio Durigan Junior
2017-04-05 16:34 ` Pedro Alves
2017-04-05 16:45 ` Sergio Durigan Junior
2017-04-05 16:49 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3704b36-88c2-ac80-c75e-b132a3ff1980@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox