From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65939 invoked by alias); 5 Apr 2017 16:49:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65640 invoked by uid 89); 5 Apr 2017 16:49:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=Hx-languages-length:728 X-HELO: mail-wr0-f178.google.com Received: from mail-wr0-f178.google.com (HELO mail-wr0-f178.google.com) (209.85.128.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 16:49:43 +0000 Received: by mail-wr0-f178.google.com with SMTP id w11so21483662wrc.3 for ; Wed, 05 Apr 2017 09:49:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=BYChK72i9K/fUiFJUFv//uSFOmgqa72yP/PpovH3Pvk=; b=IMnF3w6xxs3X5CNZoHlJRbrUrIEMm/XauBB+1MeMcAGqPb0mTmTwwRY7qz8q3hEyb3 FIYqzFA9KjZd/qnAT7hC9VhmRnVRWHYk2VKj9azRtPN/LGKvogOeOtoufQFWBeGXNaLw MUMj76HNXleW7w9q8HciBjtOOxZSVn5TEqmQrFkZ9pAOHM0RINc3ytOn/+owsd7bDsZX oO0OyRpH0gENPreqSZ7btrajezo3Ec5QG+3vG+//wV/IkFmH+yUq7p5iad8eKEwVnq5N Y33Vao3IwEnQKgADAUbt9sV/+zwmUruq+bIOeFl1SGrJuxlRppV6fIyTGKftvmWz3Epv C+5Q== X-Gm-Message-State: AFeK/H15q2Wjhwd2uWs/8JzL6vQNUkMdMIwDb/lj9NZpaiNCXZAOlPrFwiyxT30e1740PnM8 X-Received: by 10.223.171.11 with SMTP id q11mr27523072wrc.35.1491410982801; Wed, 05 Apr 2017 09:49:42 -0700 (PDT) Received: from [192.168.0.100] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id 204sm23054257wmw.0.2017.04.05.09.49.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 09:49:40 -0700 (PDT) Subject: Re: [commit/obvious] Fix PR 21352: Command tsave does not support -r argument To: Sergio Durigan Junior References: <20170405163129.24815-1-sergiodj@redhat.com> <8d200237-58fe-45c3-c0a6-2f15413a988b@redhat.com> <87bmsa9517.fsf@redhat.com> Cc: GDB Patches From: Pedro Alves Message-ID: Date: Wed, 05 Apr 2017 16:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87bmsa9517.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00121.txt.bz2 On 04/05/2017 05:45 PM, Sergio Durigan Junior wrote: > On Wednesday, April 05 2017, Pedro Alves wrote: > >> On 04/05/2017 05:31 PM, Sergio Durigan Junior wrote: >>> This is an obvious fix for PR 21352. The problem is that the argument >>> parsing loop is not using an "else if" where it should, and therefore >>> the '-r' option ends up unrecognized by GDB. >> >> We have a few tests under gdb.trace/ that exercise "tsave". Would it >> be easy to augment some to exercise this? > > Yes, absolutely. I was thinking about doing that but decided not too. > Anyway, here's what I checked in. Thanks, I like the new decision better. :-) -- Pedro Alves