Sent a patch to the bug database - Retrieve long long from Python

Sent a patch to the bug database - Retrieve long long from Python

[Noam Yorav-Raphael]

Hello,

I just wanted to say that I sent a small bug report + patch to the bug
database, at
http://sourceware.org/bugzilla/show_bug.cgi?id=10583

(It's about converting from long long ints to python longs)

Is this ok? Do you prefer that I send patches like this directly to
this mailing list?

Thanks,
Noam

Re: Sent a patch to the bug database - Retrieve long long from Python

[Joel Brobecker]

> Is this ok? Do you prefer that I send patches like this directly to
> this mailing list?

It certainly makes it easier for us to review your patches if you
send them to this list. Can you also write a testcase for your patch,
so that we don't accidently regress?

Thanks,
-- 
Joel

Re: Sent a patch to the bug database - Retrieve long long from Python

[Tom Tromey]

>>>>> "Noam" == Noam Yorav-Raphael <noamraph@gmail.com> writes:

Noam> I just wanted to say that I sent a small bug report + patch to the
Noam> bug database, at
Noam> http://sourceware.org/bugzilla/show_bug.cgi?id=10583

Noam> (It's about converting from long long ints to python longs)

Noam> Is this ok? Do you prefer that I send patches like this directly to
Noam> this mailing list?

For a non-trivial patch we will need you to fill out copyright
assignment papers.  This patch is small enough that we can accept it,
but if you plan to do any more work on GDB, then it is good to get this
out of the way early; send me email off-list and I will get you started.

Also, we require ChangeLog entries for patches.  See the GNU Coding
Standards for information on writing those.

I think we should probably look at the value in valpy_int and valpy_long
and return the shortest possible of int, long, or long long.

The docs for this part of Python seem quite lacking.

Tom