From: Simon Marchi <simark@simark.ca>
To: Joel Brobecker <brobecker@adacore.com>,
Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gnulib: Ensure all libraries are used when building gdb/gdbserver
Date: Mon, 12 Oct 2020 10:16:08 -0400 [thread overview]
Message-ID: <b0ab1bdf-33a6-8df6-a702-c4d75254d382@simark.ca> (raw)
In-Reply-To: <20201012114130.GA28251@adacore.com>
On 2020-10-12 7:41 a.m., Joel Brobecker wrote:
> I got reports of the nightly source packaging failing soon after
> you pushed this patch, and I was able to reproduce it by configuring
> (out of tree), followed by a "make distclean". I did a "make -C gdb install"
> as well, but I don't think it should have any influence on the outcome.
>
> The error I get is the following:
>
> | Makefile:246: ../gnulib/Makefile.gnulib.inc: No such file or directory
> | make[2]: *** No rule to make target '../gnulib/Makefile.gnulib.inc'. Stop.
> | make[2]: Leaving directory '/[...]/gdb'
>
> Do you think you could look into it?
Ah, that's a case I didn't think of. When make distclean runs, it runs
first in gnulib, so erases gnulib/Makefile.gnulib.inc. When it then
runs in gdb, the Makefile can't run.
So I guess we'll need to make the inclusion condition/non-fatal for this
reason, unless you see another way?
Simon
next prev parent reply other threads:[~2020-10-12 14:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 16:51 Andrew Burgess
2020-10-05 18:34 ` Simon Marchi
2020-10-06 12:17 ` Andrew Burgess
2020-10-06 14:10 ` Simon Marchi
2020-10-07 15:33 ` Andrew Burgess
2020-10-07 15:34 ` Simon Marchi
2020-10-09 8:34 ` Andrew Burgess
2020-10-12 11:41 ` Joel Brobecker
2020-10-12 14:16 ` Simon Marchi [this message]
2020-10-12 15:30 ` Andrew Burgess
2020-10-13 14:26 ` Simon Marchi
2020-10-14 14:09 ` Andrew Burgess
2020-10-15 8:35 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0ab1bdf-33a6-8df6-a702-c4d75254d382@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox