From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1FQ/JC1lhF/9aQAAWB0awg (envelope-from ) for ; Mon, 12 Oct 2020 10:16:13 -0400 Received: by simark.ca (Postfix, from userid 112) id 856181EF6F; Mon, 12 Oct 2020 10:16:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 012C01E58D for ; Mon, 12 Oct 2020 10:16:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 68B4A386F446; Mon, 12 Oct 2020 14:16:12 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DA23C386F446 for ; Mon, 12 Oct 2020 14:16:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DA23C386F446 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 788E71E58D; Mon, 12 Oct 2020 10:16:09 -0400 (EDT) Subject: Re: [PATCH] gnulib: Ensure all libraries are used when building gdb/gdbserver To: Joel Brobecker , Andrew Burgess References: <20201005165134.1620549-1-andrew.burgess@embecosm.com> <2feb66c2-8f65-7cbf-d1be-ae3d04b45d9a@simark.ca> <20201006121751.GK605036@embecosm.com> <95d52add-47c2-9621-7e60-1ff9a4331324@simark.ca> <20201007153319.GL605036@embecosm.com> <20201009083436.GP605036@embecosm.com> <20201012114130.GA28251@adacore.com> From: Simon Marchi Message-ID: Date: Mon, 12 Oct 2020 10:16:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201012114130.GA28251@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-10-12 7:41 a.m., Joel Brobecker wrote: > I got reports of the nightly source packaging failing soon after > you pushed this patch, and I was able to reproduce it by configuring > (out of tree), followed by a "make distclean". I did a "make -C gdb install" > as well, but I don't think it should have any influence on the outcome. > > The error I get is the following: > > | Makefile:246: ../gnulib/Makefile.gnulib.inc: No such file or directory > | make[2]: *** No rule to make target '../gnulib/Makefile.gnulib.inc'. Stop. > | make[2]: Leaving directory '/[...]/gdb' > > Do you think you could look into it? Ah, that's a case I didn't think of. When make distclean runs, it runs first in gnulib, so erases gnulib/Makefile.gnulib.inc. When it then runs in gdb, the Makefile can't run. So I guess we'll need to make the inclusion condition/non-fatal for this reason, unless you see another way? Simon