From: Jan Beulich <jbeulich@suse.com>
To: Nelson Chu <nelson@rivosinc.com>
Cc: Charlie Jenkins <charlie@rivosinc.com>,
gdb-patches <gdb-patches@sourceware.org>,
Binutils <binutils@sourceware.org>, jiawei <jiawei@iscas.ac.cn>,
Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 1/2] RISC-V: Fix abort when displaying .dword
Date: Wed, 12 Feb 2025 11:06:48 +0100 [thread overview]
Message-ID: <b088627c-5fa5-4df8-a6e5-e0698abe7760@suse.com> (raw)
In-Reply-To: <CAPpQWtCXhkyhG++ANqApiKBd2OupiH5jGuJ6dQYsafdV+ZmRaQ@mail.gmail.com>
On 12.02.2025 09:57, Nelson Chu wrote:
> On Wed, Feb 12, 2025 at 4:06 PM Jan Beulich <jbeulich@suse.com> wrote:
>
>> While this follows what's done in the 3-byte case, I don't consider this
>> (or the 3-byte logic) correct. When I see .dword, I expect what's printed
>> covers full 8 bytes. Imo fake .<N>byte directives (which the assembler
>> doesn't recognize for non-power-of-2 N) would be more logical to use.
>
> Well if I see .word, I also expect to print the full 4 bytes, so probably
> just remove the case 3, and then make sure that we only have 1/2/4/8 for
> data, which means .byte/.short/.word/.dword.
Except that there is no 4th byte to print in that case. That wants expressing
somehow, without taking a value out of thin air.
Jan
next prev parent reply other threads:[~2025-02-12 10:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 5:08 [PATCH 0/2] RISC-V: Fix abort when displaying data and add test Charlie Jenkins
2025-02-12 5:08 ` [PATCH 1/2] RISC-V: Fix abort when displaying .dword Charlie Jenkins
2025-02-12 5:27 ` Jiawei
2025-02-12 7:25 ` Alan Modra
2025-02-12 8:06 ` Jan Beulich
2025-02-12 8:57 ` Nelson Chu
2025-02-12 10:06 ` Jan Beulich [this message]
2025-02-12 22:15 ` Maciej W. Rozycki
2025-02-13 0:51 ` Charlie Jenkins
2025-02-13 0:52 ` Charlie Jenkins
2025-02-12 5:08 ` [PATCH 2/2] RISC-V: Add testcase for 6 byte instruction Charlie Jenkins
2025-02-12 5:20 ` [PATCH 0/2] RISC-V: Fix abort when displaying data and add test Nelson Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b088627c-5fa5-4df8-a6e5-e0698abe7760@suse.com \
--to=jbeulich@suse.com \
--cc=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=charlie@rivosinc.com \
--cc=gdb-patches@sourceware.org \
--cc=jiawei@iscas.ac.cn \
--cc=nelson@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox