Re: [PATCH 0/2] RISC-V: Fix abort when displaying data and add test

[Nelson Chu <nelson@rivosinc.com>]

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]

I think this resolved the segfault when dumping partial data which size
between 4 and 8.  Before this series, we used to dump "out of bounds
address", so after adding this last piece of the puzzle will be perfect for
now.  The only thing I can imagine is that we probably need to handle the
dump_size between 8 and 16 if supporting rv128, but we can handle that
later at that time.

Hi Nick, Hi Alan, Hi Jan,

I think we should also backport this to 2.44 branch, is that good?

Thanks a lot
Nelson


On Wed, Feb 12, 2025 at 1:08 PM Charlie Jenkins <charlie@rivosinc.com>
wrote:

> Commit 6a04e8230707 ("RISC-V: Fix display of partial instructions")
> changed how objdump displays instructions. This had the unintented
> side-effect that it allowed 6 byte instructions to be displayed which
> happens when a .dword is attempted to be split into instructions. Add
> support for 5, 6, and 7 byte instructions to remedy this
> issue.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> ---
> Charlie Jenkins (2):
>       RISC-V: Fix abort when displaying .dword
>       RISC-V: Add testcase for 6 byte instruction
>
>  gas/testsuite/gas/riscv/dis-partial-insn-dword.d | 12 ++++++++++
>  gas/testsuite/gas/riscv/dis-partial-insn-dword.s |  2 ++
>  opcodes/riscv-dis.c                              | 29
> +++++++++++++++++++++++-
>  3 files changed, 42 insertions(+), 1 deletion(-)
> ---
> base-commit: 815d9a14cbbb3b81843f7566222c87fb22e7255d
> change-id: 20250211-fix_gas_abort-6d1e28b4ad46
> --
> - Charlie
>
>

[-- Attachment #2: Type: text/html, Size: 2098 bytes --]