From: Luis Machado <luis.machado@linaro.org>
To: Simon Marchi <simon.marchi@polymtl.ca>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Alan Hayward <Alan.Hayward@arm.com>
Subject: Re: -Wtautological-bitwise-compare error in arm-tdep.c
Date: Mon, 25 May 2020 10:51:24 -0300 [thread overview]
Message-ID: <b020084f-e99b-f5b3-599f-d677d848e468@linaro.org> (raw)
In-Reply-To: <91440d8b-14c9-611f-ebfd-4cc209c05af8@polymtl.ca>
On 5/25/20 10:49 AM, Simon Marchi wrote:
> On 2020-05-25 9:08 a.m., Luis Machado wrote:
>> This fixes an instruction mask typo. We should be matching only
>> ldrd (immediate) and not any other of its variants. As is, it never matches
>> anything.
>
> And moreover, within the `ldrd (immediate)` instruction, it only matches the
> `Offset variant` variant, right?
>
That's right. We don't want to handle anything that changes the SP here.
And the post-indexed and pre-indexed variants do so.
>>
>> With the patch, the instruction mask also allows matching of ldrd (literal),
>> but the check for SP discards this particular instruction pattern, as it has
>> a hardcoded PC register.
>
> I don't feel the most qualified to approve this patch. Alan, could you please
> take a look?
>
> Simon
>
next prev parent reply other threads:[~2020-05-25 13:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 20:32 Simon Marchi
2020-05-15 20:41 ` Luis Machado
2020-05-15 20:57 ` Simon Marchi
2020-05-25 13:08 ` Luis Machado
2020-05-25 13:49 ` Simon Marchi
2020-05-25 13:51 ` Luis Machado [this message]
2020-05-26 9:45 ` Alan Hayward
2020-05-26 12:17 ` Luis Machado
2020-05-26 16:10 ` Alan Hayward
2020-05-27 12:43 ` Luis Machado
2020-05-27 14:00 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b020084f-e99b-f5b3-599f-d677d848e468@linaro.org \
--to=luis.machado@linaro.org \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox