From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by sourceware.org (Postfix) with ESMTPS id ACA58383E820 for ; Mon, 25 May 2020 13:51:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ACA58383E820 Received: by mail-qv1-xf30.google.com with SMTP id d1so8044577qvl.6 for ; Mon, 25 May 2020 06:51:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p4JzTGjfTZiBbHFjWXX35N6J0Anov11UjMvOKyNqhSE=; b=s0JZglxhf7zOR9r8E8K21sOVXgMljUIw0OZkXK34JqPo/97SxCajRXVixy7+cG+wWZ /c3WHOiExwCKHyIfeK+S2sH2n39T51kJS0fIWeY4lPr9Syn5U5Ls7dC47zXTIedhF4Gh 2su7OFjGj+odtD7Tevqti9/6qY5YAxR8vKATSZ7Jna1DD9e4/xsRNRhpxirszBPtBB7z 6DftYvN0Gz8Z1oXx9CNQZQDNL9w6JU8vYxCorIElw4+JdOI9p5nnmJyS7wCHI0DLIoho TzSFCxvVMLiBaf7bOzttyloQBbgOSz87Hmwx/oBjl1YYXHc2JqSnOjAzn8885PjmhwJX Nqgw== X-Gm-Message-State: AOAM530fufWmjbsownCbxNCCuGEu4vn2IYLYCqZZVXVOeARJNL+Xu2mm KuKcZU+WLkz3iIoiQErJDTleGA== X-Google-Smtp-Source: ABdhPJwUiwhDS5PFVvbg++kPGC8BsJUjIGsZcsD79siE4Fe7l8CsyiUHpuTxAHChQ8u+CxGEv6IkiA== X-Received: by 2002:a0c:ec08:: with SMTP id y8mr14629353qvo.7.1590414689211; Mon, 25 May 2020 06:51:29 -0700 (PDT) Received: from [192.168.0.185] ([179.185.148.238]) by smtp.gmail.com with ESMTPSA id j7sm2433955qkk.63.2020.05.25.06.51.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2020 06:51:28 -0700 (PDT) Subject: Re: -Wtautological-bitwise-compare error in arm-tdep.c To: Simon Marchi , "gdb-patches@sourceware.org" , Alan Hayward References: <98a9d90b-0452-5b53-b707-9441ebcad6b7@linaro.org> <91440d8b-14c9-611f-ebfd-4cc209c05af8@polymtl.ca> From: Luis Machado Message-ID: Date: Mon, 25 May 2020 10:51:24 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <91440d8b-14c9-611f-ebfd-4cc209c05af8@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 13:51:30 -0000 On 5/25/20 10:49 AM, Simon Marchi wrote: > On 2020-05-25 9:08 a.m., Luis Machado wrote: >> This fixes an instruction mask typo. We should be matching only >> ldrd (immediate) and not any other of its variants. As is, it never matches >> anything. > > And moreover, within the `ldrd (immediate)` instruction, it only matches the > `Offset variant` variant, right? > That's right. We don't want to handle anything that changes the SP here. And the post-indexed and pre-indexed variants do so. >> >> With the patch, the instruction mask also allows matching of ldrd (literal), >> but the check for SP discards this particular instruction pattern, as it has >> a hardcoded PC register. > > I don't feel the most qualified to approve this patch. Alan, could you please > take a look? > > Simon >