Re: [PATCH] Introduce "set debug separate-debug-file"

[Simon Marchi <simon.marchi@ericsson.com>]

On 2017-05-25 01:07 PM, Pedro Alves wrote:
> I think this is a good idea.
> 
> You're missing NEWS and manual bits though.
> 
> On 05/25/2017 12:24 AM, Simon Marchi wrote:
> 
>> +      if (separate_debug_file_debug)
>> +	printf_unfiltered ("  Trying %s\n", link);
>> +
> 
> Missing "_()" in several of these new calls.
> 
>> +
>> +  add_setshow_boolean_cmd ("separate-debug-file", no_class,
>> +			   &separate_debug_file_debug, _("\
>> +Set printing of separate debug info file search debug."), _("\
>> +Show printing of separate debug info file search debug."), _("\
>> +When on, GDB will print the searched locations while looking for separate \
>> +debug info files."), NULL, NULL, &setdebuglist, &showdebuglist);
> 
> FWIW, I think it's better to avoid future tense when possible:
> 
>   "When on, GDB prints the searched locations"

Thanks for the comments, sending a v2 now.

Simon