From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47436 invoked by alias); 25 May 2017 11:33:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47399 invoked by uid 89); 25 May 2017 11:33:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 May 2017 11:33:07 +0000 Received: from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 5C.49.02011.3F0C6295; Thu, 25 May 2017 13:33:08 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.39) with Microsoft SMTP Server (TLS) id 14.3.339.0; Thu, 25 May 2017 13:33:07 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from [192.168.0.32] (80.216.243.234) by AM4PR07MB1715.eurprd07.prod.outlook.com (2603:10a6:200:26::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.5; Thu, 25 May 2017 11:33:05 +0000 Subject: Re: [PATCH] Introduce "set debug separate-debug-file" To: Pedro Alves , References: <1495668248-16716-1-git-send-email-simon.marchi@ericsson.com> From: Simon Marchi Message-ID: Date: Thu, 25 May 2017 11:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR09CA0051.eurprd09.prod.outlook.com (2603:10a6:802:28::19) To AM4PR07MB1715.eurprd07.prod.outlook.com (2603:10a6:200:26::23) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM4PR07MB1715: X-MS-Office365-Filtering-Correlation-Id: 07bc0ae4-1e7e-4405-20bd-08d4a361cfeb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:AM4PR07MB1715; X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1715;3:SWxa8Pr6P7i9yGadILZoGu8dlcn5ZAEzqc5N9KJ/OoCLB2aoaRL7uDAGUR+K+zIJTEkRNfckB6zxfvJvihHyTCEuY/lXVgd85MjuoCm/G9ra9rT2eFKABOXkrPOMQYU2pmqgSeTFH/j9TEALNUrw7BVJ3JYXHJUMzSp1D4RWOz3JqSXJ1FXCeZ2226+7kbxsHS3Ys79BLKrMYLiTVVaEb1mW4bN//tsK3VWzwSFQy9uG/hdgo1J4xBy7d0rVzNnRVyNbpnBbPaGN4ByIMuTRx3cemmUAyP80RWvtiphLIUHIoTZDkucPVSh1uTdPxNOiV+evUHjM8fFVKPcMBtx9tg==;25:K9mXlsvDOC7y6rsagpU3j/BdmuaeD+9FYO+CUd/avIXlQITXc0RqAcpiDu7n7sEk2KytrXV1xtJJJnS25qdVSAEBfgnJ+p0SFz93syO8jUCqUSFLxrqre8lkMjy4GWcejOY3EOGZd3N//ljQWEXQJ214v3xp+iQxXN00kyn95Y8bDe0yzk5xEA2DTLt1XzbVuf+FE6ZW4I/TWdiUklRm+VCM6/3xxiNP6OXvFoAVfP7ylBJhaQjubWA1z2NUFm0Mud8gjZCDpfhl0a4bvccuoLnjcyY/q/oOQPdMOZQvH7DN9voPVKUj6Ku1dQzy7E8kcVxOwwOmfV4O93PTQwRqH9MxvEm2jo7bSROYLZZPNfxohREmO+e8/5IrQjcZ3CmreJ5rTcASkoh8NhVTvdsS9M1k2BUWuDo/80k1dVmSCzSqSZSwNveyjFcHI9zACa1QC1G5q66az5y/HOhEI5HdkMnE3W0sGhFj7+HX9r+CYIM= X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1715;31:Qyl6/RXfW7xF+mGuw4eHvMNdoUQnuXWa/tCHc/ajxoZeVT5w8/euXquFEKW1ha0xskYNVf427BKWHBDQ5BiJG2dB5/m6EUh0nTGv/mRPxCCH9z68qcHDRtngHyaSLSM1iKIwL2tIVfuC4qVutP8OwV0CjPZOuPP7QB3bzZXFSX4uXIZkkN2ivobxZ0YG2TQIy/w6dmJGAAjxC2JZLhGSph7k+GEiz8az20/KHEwJ5/s7qP+EBoEFecwpOh8d5oNnz9+rsxWy023I3DPlgWpIXg==;20:GDSlyTaBhziNnetT/wTfQhmnhIpPWkwjJV3y9wwwYFFVg8dSuAoXcRiRzREbhUVco9We+8XMwPo02e02URTYEope9nhlA2DQl7adatANCTjL/K1ZAfllIo40r7R2tGvV+T8dyGoJJU1MfnEUDmEhkLfSFIVyiCzmbFC47D3gm+eyKiwmKTaQHe1Pwn2eAdIgIJk4TngBpEVZkuMs025z8cOrXQjz1Kx1piAx8diESyWwbx0dlXlUqIC+7lHPo8+dLPVdbmWV/AiNvis4s2PtNOGtH1GJPiWl+Hpxl9rGVP3V3TQLkjZ6CIqY3Yh1QpFlIS1g5KAbzNV5bdy6A0Z00fbU7plsxB/W2qzarTAAizS5P7KgKlCliY+U/GszsFTaPckT7oB4qN10Zq95qVhavY0b8HciZPFMT8QCKFSQLteifTiRDs2hZm6B/aAs1qvmGKV+W7C1sg+SNCIlYhYCzIJMt2hfYIDCNBvbXSHochiTIe9jKMdkUIj061oJNdcn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(6072148);SRVR:AM4PR07MB1715;BCL:0;PCL:0;RULEID:;SRVR:AM4PR07MB1715; X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1715;4:bXCwQLDvdUa+/LFq2/fAxo5OCcThq80k3Ou482Y1N43nQVqzQaWcFGJo6pumzPrZCT/cnpprBG74HDsk4W7SQ1b9aaf08XYOSTbaNX/+ZeTVb+o+pWi5CXzBKecoL5w8uunVNXGjs9mzIu98o09BB8B08PXbbR1t13bldeIBuaDY4D5qg1lAXLR84oY0GUbss4koPHxl6Y4lk58p4cEtGhT533fVymmvukfcoRA+VCGeuaIX3e8+v6+ulu7ZP5/g6nm/BBXEQXR9PWIAN+QZApaR+q0sJW24k02hCbHQLhMo/ycvbjrfgSF7N/0QbzshuCEGHqzw6z0iqmMNuX4P7weS8pyja1AbQ05/XnnAAHC61truyi0esK9eOctGlKkBWefxjX9tz/AgfNkCYzdbdC4XMBqOvwQ3U4Z9H6zsfBcdK+0hwebYz7TlB1sfJY5hGOD2fVdzALHkkbW7baA8+3u2PfWW7KKgB/qfXmEDgQEvQAzQ+NiT+l9pYqMbHcxAvxIufVhn5Wr9HUUEqJFvsIRAfn5LjdUdQup4ctJvR094dKi75iN0ScIlIFumOxTxOyWAgnQJqreap/P/9JRC6/HDRgHC6+CdFv7brNoqM7H8MEE5nETuPQTYy6/uMathJN90R1UApqAM25bk1F12YMhE5WtefK1o0y3B8hVUytzFzbIdk+SNCtdrGaW1wnzKqZ+weE17ejnA6T+EWuY71eHzRQnLTJHPv50jCUsdBKzu+iPFSssvkGIH1DJ3D78zrC3d2WUjdXzeEjc83iOEfzAYrmXNPT620IauZiH9ck8= X-Forefront-PRVS: 0318501FAE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39400400002)(39850400002)(39450400003)(39410400002)(39840400002)(39860400002)(24454002)(377454003)(51914003)(377424004)(77096006)(478600001)(42186005)(6486002)(4001350100001)(64126003)(6116002)(3846002)(31686004)(2906002)(53936002)(83506001)(6246003)(86362001)(31696002)(23746002)(50466002)(8676002)(81166006)(53546009)(5660300001)(25786009)(54356999)(76176999)(50986999)(66066001)(65956001)(33646002)(305945005)(189998001)(38730400002)(6666003)(230700001)(117156002)(230783001)(65826007)(2950100002)(229853002)(36756003)(47776003)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR07MB1715;H:[192.168.0.32];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR07MB1715;23:TPA/qYl8LQ2rM97TPDtqn1EZdO0c7LdK8rO+T?= =?Windows-1252?Q?Y4HohVdFh9Qo4Sum9t1CJ9Eu74qFbnMRxJMFSzLbFzicmo7skcMIJnHL?= =?Windows-1252?Q?tc/DuM3O2vUealYLlfmzNhbCVK68S+ZzmTJF+jnqmglxS6u5WsHZrPss?= =?Windows-1252?Q?0NfKuT72eUPFKeP5HlnG/YH0UuxIYfQGjK1pvwQy017D2ET4pLLx3J2r?= =?Windows-1252?Q?kSuxV+6vRc0QHTBouc/TXg9bnHIfKgu2zUCMEVH1Dw8Qf4MsHiIRoYdh?= =?Windows-1252?Q?k4pTBcjdbHmNxaN1lQ8QoG/4pSEyzE/ie8IUmwEXjUohZhwrur31AxSq?= =?Windows-1252?Q?Pvhywj1dcPuR5mze8lLrH7mqubx1zUhnul+7vcF2OAAVEnACNL5dPDHL?= =?Windows-1252?Q?QpCDeOXuKuNmpBjIHJLobi7YqL8KhIQMIsbDX9LYkIyBO+kHgh4aUxSA?= =?Windows-1252?Q?rOgPhcZRWSPmrCLe2MOAA3SRlUnAT+3dkL+igGw7LPk4xpvAkIfFhC1u?= =?Windows-1252?Q?co1VtB7xf95dre9oAjj9RjMbkEG0Eq1WonZy2pH5t+JDDd7BoQn8Q3+y?= =?Windows-1252?Q?9tdvW/sKMz072fI34pHxTG7UzWPm3b4Z8KpRekgGeurDjvv3nIdg7JKF?= =?Windows-1252?Q?qQZINMUS5e1gz66fH6bRuqTgCTRfNksdgXOFSm5pMv3z0yivxRHAhMcE?= =?Windows-1252?Q?1kUoyblid/jB2XUlmPWqjKKL/eSh/mvLtZWDpEqADm0R+f9hDjmT50aR?= =?Windows-1252?Q?C5DpIXuc2aCxbl3K4GZUKQH9T0nzTk9WA0YZlFv+nCR8wSUVQjofllLr?= =?Windows-1252?Q?8r8uuqAUUAbFI4YyV0Q5Hh1NVfr8VBgIzGNnBUiTaMyp7wB5LdEPyYi2?= =?Windows-1252?Q?Y429JU/q7PRPKAvwBJp2/vsaSv80M71wqNwHPDoa1b+8YIvJqmYN1qNU?= =?Windows-1252?Q?YSruvhOHbtdk/PIs9cRoHdpphvvIdW5uMWXCXmlo19llu7kDMAHpPzvk?= =?Windows-1252?Q?j9rqfo1lC5GP62P4sEG6MRgbEyDMl631lt6zl9xQqZuG1IkbkYOAJkGP?= =?Windows-1252?Q?X8bBiXvaw/XlyAOppU0PUXScEd0Q+K0SAjMzjQgsVAdrv3lmzNrhhdFX?= =?Windows-1252?Q?TWe8cS2HpqYyZ+o+iuIzjb0O91LQB+zLsghSF+BgCnp6A3hy+3n6pLIS?= =?Windows-1252?Q?irGXtkBVdifO5jRbUAgUB0x7VwPUkKlEIf/egsgEEscJzxaePnbbirOT?= =?Windows-1252?Q?IipeTDaKJhSvcDJsInZ/WNuMAtTX/4YGRT3yb+SCjTrb+3HEnsnLSUKg?= =?Windows-1252?Q?j3sAcsTwfbzYdDqS5nGZAuGP/ZPYLeK7GFdEOTXO9inQeHqjazG6S438?= =?Windows-1252?Q?KgdpJxrTjX7+Y0CwDp8/rzbGp3f2yiU/wKn6uR1QFgcUCTj/xzb2QQZG?= =?Windows-1252?Q?vrj7Mo/MxB6lLQM3NNB?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1715;6:oHASt/4N6U0U9FpdWLIBg9w2EZnzRHVAZ8tRkBU1+8Bf3mAD/TCMqiP/zkwEdvBWDqc1cMKT6aLA3rZIt9KC0++blqsKDQTjQx0hNGq5QHtvlvWhNlXNdHIWvxUGQakCtl8i/r1NIkGOlgcT2HqeKhjBt9D3x+AWUOG8srVp8Cw1yBuLgv9uJt2Yef8ptBuCCIhsHtnGb+T4YDPpd1KvYW9iNuqkr+0/foJ1uCQAtHHsxmOF920P8+IOC7a7clegpvbcqgai7btokGWbTlPQqfN/hEcd15/F14tTS7oJW5280qGOq55Tsi1sCWlKhiibZDnVE9Sx0d6f/tnG90M1HJjEHKGKk8czV6+I3GgW29vPhV9L0C5YlI8p3PW7cq6j0xb5hzcx/s/t7QijyC7dmRiBAyR9pagO3jX/1nUF5iOKn5SVMpJeUWnwoL5h5GizzNqrNRTLyfM1kmrNTBKFw9ES6m9l734G1NUPRVKFujJiixlPE1zHdvCffDxsZ4btCVE0x2T6w9sxRlz0N83zMQ==;5:R48Km+WyrfbK1aY8/lkK0yV16yZrHeO5tcG4Y7NLubmZy5fftuMaP9KnOSyq2+a/BIpXeCu8Zu+2BWfFwYHP3nCzzZZy1V3HXG/gROmfUTk4ORZx6yFQ26yA3szMEmosVLW+CAb95S9khkUbyuBPk/sjx6N7p5ud2DOJTB1EqcQ=;24:QmyT5M2fghPBx7GpnpBdYcdkPqQ21V41y9tzczBc0z9yv6kJs1UouqleFU4B04AEU1GgcuwjO7siNGsabpHOoSwFmbVd1sGv1+N/8uqPEmE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1715;7:EW77D8yPZBUKoWtWc4w77ebQ5OQ9X++djKkVpXsXT1QtJBVTMwK4YvG7nrV6ctZvZSV8IyyRwURFrv8Zz0E5Iuhch4Txniea1pzHkATDIdv09oy7AweSb8NMyIVCk7Kvy4Hu3rw3mTo+gWVS1sgQmT430rSRVtfzojn5Whu7c2in4nx3IOSNOjUTB52RCbFqf6kM+dEJhSVJcBbC6qKy8RKeFe3krP0G9WnWjr05afp6lo1J3uQ8FhKrhmSiIa6BnB737fzbeWBHwDAglX7rSoEJl8joI34aQq/aH/GK/UUQLToYaaLSM5OlhFR62q3CM5z6d4YyoaH1U/Txrly3pA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2017 11:33:05.8405 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB1715 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00539.txt.bz2 On 2017-05-25 01:07 PM, Pedro Alves wrote: > I think this is a good idea. > > You're missing NEWS and manual bits though. > > On 05/25/2017 12:24 AM, Simon Marchi wrote: > >> + if (separate_debug_file_debug) >> + printf_unfiltered (" Trying %s\n", link); >> + > > Missing "_()" in several of these new calls. > >> + >> + add_setshow_boolean_cmd ("separate-debug-file", no_class, >> + &separate_debug_file_debug, _("\ >> +Set printing of separate debug info file search debug."), _("\ >> +Show printing of separate debug info file search debug."), _("\ >> +When on, GDB will print the searched locations while looking for separate \ >> +debug info files."), NULL, NULL, &setdebuglist, &showdebuglist); > > FWIW, I think it's better to avoid future tense when possible: > > "When on, GDB prints the searched locations" Thanks for the comments, sending a v2 now. Simon