* [OB PATCH] Fix configure.srv error for Linux on PowerPC
@ 2020-01-29 17:59 Pedro Franco de Carvalho
2020-01-29 18:10 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Franco de Carvalho @ 2020-01-29 17:59 UTC (permalink / raw)
To: gdb-patches; +Cc: ulrich.weigand, rcardoso, macro
An error in commit 42cd72aa0279520384327a1f6d0ebd2eb2200645 caused
srv_tgtobj to be overwritten and linux-ppc-low.o to be missed when
linking gdbserver for Linux on PowerPC. This patch fixes the error.
gdb/gdbserver/ChangeLog:
2020-01-29 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
* configure.srv (powerpc*-*-linux*): Use srv_tgtobj in second
assignment instead of srv_linux_obj.
---
gdb/gdbserver/ChangeLog | 5 +++++
gdb/gdbserver/configure.srv | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index a97e408202..3b88a9b901 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2020-01-29 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
+
+ * configure.srv (powerpc*-*-linux*): Use srv_tgtobj in second
+ assignment instead of srv_linux_obj.
+
2020-01-28 Hannes Domani <ssbssa@yahoo.de>
* server.c (handle_qxfer_libraries): Write segment-address with
diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv
index 8437c1ace0..f0ab14f7c3 100644
--- a/gdb/gdbserver/configure.srv
+++ b/gdb/gdbserver/configure.srv
@@ -211,7 +211,7 @@ case "${target}" in
srv_regobj="${srv_regobj} powerpc-isa207-vsx64l.o"
srv_regobj="${srv_regobj} powerpc-isa207-htm-vsx64l.o"
srv_tgtobj="$srv_linux_obj linux-ppc-low.o"
- srv_tgtobj="$srv_linux_obj nat/ppc-linux.o"
+ srv_tgtobj="${srv_tgtobj} nat/ppc-linux.o"
srv_tgtobj="${srv_tgtobj} arch/ppc-linux-common.o"
srv_xmlfiles="rs6000/powerpc-32l.xml"
srv_xmlfiles="${srv_xmlfiles} rs6000/powerpc-altivec32l.xml"
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [OB PATCH] Fix configure.srv error for Linux on PowerPC
2020-01-29 17:59 [OB PATCH] Fix configure.srv error for Linux on PowerPC Pedro Franco de Carvalho
@ 2020-01-29 18:10 ` Maciej W. Rozycki
2020-01-29 18:13 ` Pedro Franco de Carvalho
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2020-01-29 18:10 UTC (permalink / raw)
To: Pedro Franco de Carvalho; +Cc: gdb-patches, ulrich.weigand, rcardoso
On Wed, 29 Jan 2020, Pedro Franco de Carvalho wrote:
> An error in commit 42cd72aa0279520384327a1f6d0ebd2eb2200645 caused
> srv_tgtobj to be overwritten and linux-ppc-low.o to be missed when
> linking gdbserver for Linux on PowerPC. This patch fixes the error.
Ouch, sorry for the paste thinko and thanks for the fix!
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [OB PATCH] Fix configure.srv error for Linux on PowerPC
2020-01-29 18:10 ` Maciej W. Rozycki
@ 2020-01-29 18:13 ` Pedro Franco de Carvalho
0 siblings, 0 replies; 3+ messages in thread
From: Pedro Franco de Carvalho @ 2020-01-29 18:13 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: gdb-patches, ulrich.weigand, rcardoso
"Maciej W. Rozycki" <macro@wdc.com> writes:
> On Wed, 29 Jan 2020, Pedro Franco de Carvalho wrote:
>
>> An error in commit 42cd72aa0279520384327a1f6d0ebd2eb2200645 caused
>> srv_tgtobj to be overwritten and linux-ppc-low.o to be missed when
>> linking gdbserver for Linux on PowerPC. This patch fixes the error.
>
> Ouch, sorry for the paste thinko and thanks for the fix!
>
> Maciej
No worries!
I also noticed that the line in configure.srv for i[34567]86-*-mingw*)
is missing a line break, but I don't have a mingw setup to test a fix
and send it.
Thanks!
--
Pedro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-29 18:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 17:59 [OB PATCH] Fix configure.srv error for Linux on PowerPC Pedro Franco de Carvalho
2020-01-29 18:10 ` Maciej W. Rozycki
2020-01-29 18:13 ` Pedro Franco de Carvalho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox