From: Stafford Horne <shorne@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Stafford Horne <shorne@gmail.com>,
gdb-patches@sourceware.org, openrisc@lists.librecores.org,
Franck Jullien <franck.jullien@gmail.com>
Subject: Re: [PATCH v2 1/4] gdb: Add tdesc_find_register functions
Date: Sun, 27 Nov 2016 07:09:00 -0000 [thread overview]
Message-ID: <alpine.LFD.2.20.1611271606070.29569@lianli.shorne-pla.net> (raw)
In-Reply-To: <20161127064052.GV21655@vapier.lan>
On Sat, 26 Nov 2016, Mike Frysinger wrote:
> On 27 Nov 2016 15:16, Stafford Horne wrote:
>> +/* Search FEATURE for a register REGNO and return its name. */
>
> GNU style puts two spaces after periods
Understood, sorry I didnt notice it it will be fixed in the next patch
version.
>> +char *
>> +tdesc_find_register_name (const struct tdesc_feature *feature,
>> + int regno)
>> +char *
>> +tdesc_find_register_group_name (const struct tdesc_feature *feature,
>> + int regno)
>
> seems like return values for both of these should be const
Yes, of course, this will also be fixed.
I will check against the other patches too for any similar issues.
FYI, that patches to or1k-tdep.c have detailed function comments which
dont seem to match the GNU style, any comment on that?
-Stafford
next prev parent reply other threads:[~2016-11-27 7:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 6:18 [PATCH v2 0/4] gdb: Port for OpenRISC Stafford Horne
2016-11-27 6:17 ` [PATCH v2 4/4] Add gdb for or1k build Stafford Horne
2016-11-27 6:17 ` [PATCH v2 3/4] gdb: testsuite: Add or1k l.nop inscruction Stafford Horne
2016-11-27 6:17 ` [PATCH v2 1/4] gdb: Add tdesc_find_register functions Stafford Horne
2016-11-27 6:42 ` Mike Frysinger
2016-11-27 7:09 ` Stafford Horne [this message]
2016-11-27 6:18 ` [PATCH v2 2/4] gdb: Add OpenRISC or1k and or1knd target support Stafford Horne
2016-11-29 10:06 ` Yao Qi
2016-12-22 16:11 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1611271606070.29569@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=franck.jullien@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=openrisc@lists.librecores.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox