From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28750 invoked by alias); 27 Nov 2016 07:09:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28726 invoked by uid 89); 27 Nov 2016 07:09:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:847, understood X-HELO: mail-pg0-f68.google.com Received: from mail-pg0-f68.google.com (HELO mail-pg0-f68.google.com) (74.125.83.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 Nov 2016 07:09:53 +0000 Received: by mail-pg0-f68.google.com with SMTP id x23so9748176pgx.3 for ; Sat, 26 Nov 2016 23:09:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=aL3yfRJLJUXmrgzIaoE85kSz7sqGgPmJeukpr2ucU4E=; b=O0F9FGCY0DbvM7xCeE2tDQ6jklCPEUif/jYv5K1Y4/iH9u1a0IK7rO2VLKDjVosHZM sbM4tkOrlPBn3CLnvQ+W9XQjxb/0BGVq59lDvxHnd8WeTlAA1KdnCb85cMkM7BIgCLb4 r+dbCLlX3DhufDbqHUvQM77QTkto97Hu9MjHA32JNUzZcOdHLvaxRGWp+JCst5oG2a1O ZNiY+/jHVLfVbDiKzcXo7OZKY11rR1fhef14qC/VCXgJNyQP44QaooAdzi0tfg4dcVqa UKzzK2sqWM1yg7XPe2GqKkKjWVmmm92NjVG7v5WjNqLhCsF1RNjvDYx/OLxEKkRMKNHp dYHw== X-Gm-Message-State: AKaTC01JEBNtN+V5Bvm7T+4Inpnzl51ynVM+G+QeK0s4uazQAYp7gSsEIfjy3K8gGkXgxQ== X-Received: by 10.84.195.228 with SMTP id j91mr35292381pld.88.1480230592189; Sat, 26 Nov 2016 23:09:52 -0800 (PST) Received: from lianli.shorne-pla.net (z107.124-45-178.ppp.wakwak.ne.jp. [124.45.178.107]) by smtp.gmail.com with ESMTPSA id o68sm78493907pfb.42.2016.11.26.23.09.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Nov 2016 23:09:51 -0800 (PST) From: Stafford Horne X-Google-Original-From: Stafford Horne Date: Sun, 27 Nov 2016 07:09:00 -0000 To: Mike Frysinger cc: Stafford Horne , gdb-patches@sourceware.org, openrisc@lists.librecores.org, Franck Jullien Subject: Re: [PATCH v2 1/4] gdb: Add tdesc_find_register functions In-Reply-To: <20161127064052.GV21655@vapier.lan> Message-ID: References: <20161127064052.GV21655@vapier.lan> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00910.txt.bz2 On Sat, 26 Nov 2016, Mike Frysinger wrote: > On 27 Nov 2016 15:16, Stafford Horne wrote: >> +/* Search FEATURE for a register REGNO and return its name. */ > > GNU style puts two spaces after periods Understood, sorry I didnt notice it it will be fixed in the next patch version. >> +char * >> +tdesc_find_register_name (const struct tdesc_feature *feature, >> + int regno) >> +char * >> +tdesc_find_register_group_name (const struct tdesc_feature *feature, >> + int regno) > > seems like return values for both of these should be const Yes, of course, this will also be fixed. I will check against the other patches too for any similar issues. FYI, that patches to or1k-tdep.c have detailed function comments which dont seem to match the GNU style, any comment on that? -Stafford