Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>,
	Bhushan Attarde	<bhushan.attarde@imgtec.com>,
	"gdb-patches@sourceware.org"	<gdb-patches@sourceware.org>
Subject: Re: [RFC 2/3] Record function descriptor address instead of function address in value
Date: Tue, 03 Oct 2017 18:12:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1710031902140.21915@tp.orcam.me.uk> (raw)
In-Reply-To: <CAH=s-PMimgPYr-0KDrye9b+bs0fqk2nb+tdox_VaurA8tengRQ@mail.gmail.com>

Hi Yao,

On Fri, 28 Oct 2016, Yao Qi wrote:

> >  Overall I like the proposal and if this goes forward I will see if we can
> > adapt the MIPS backend to use this approach as well, addressing the issues
> > we still have remaining, such as confusing instruction addresses and wrong
> > instruction data shown with `disass /r'.  We have a little complication in
> > that we have the ISA bit set in line information, so that would have to be
> > stripped in DWARF record processing, but it should be much easier to do
> > with a single hook in place than the complicated processing now required
> > to copy ISA bit annotation from the symbol table (msymbols), the hooks to
> > handle which we'll then be able to drop from our DWARF machinery.
> 
> At the very beginning, I wanted to follow the MIPS approach in ARM,
> but I realized some issues when writing the patch.  Then, I switched to
> the approach I am proposing in this thread.  If the ISA bit plus function
> address is regarded as a function descriptor, this approach should be
> able to handle all of them (ppc64, arm and mips) correctly (and
> cleanly, I hope).

 Have you made any progress with your solution?  I saw Ulrich had concerns 
and it's been a while, silent, since we discussed it.  Meanwhile we have 
started discovering corner case issues with compressed code disassembly, 
which I believe your change would fix.  So we'd rather avoid creating more 
hooks (hacks) addressing these issues, only to remove them again once your 
obviously more promising solution has gone in.

  Maciej


  reply	other threads:[~2017-10-03 18:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 10:53 [PATCH 0/3] Fix gdb.base/func-ptrs.exp fails in ppc64 and arm thumb mode Yao Qi
2016-10-14 10:53 ` [RFC 2/3] Record function descriptor address instead of function address in value Yao Qi
2016-10-14 17:35   ` Simon Marchi
2016-10-17 11:40     ` Yao Qi
2016-10-17 15:40       ` Simon Marchi
2016-10-17 15:51   ` Ulrich Weigand
2016-10-18  2:27     ` Maciej W. Rozycki
2016-10-18 13:03       ` Yao Qi
2016-10-28 16:20       ` Yao Qi
2017-10-03 18:12         ` Maciej W. Rozycki [this message]
2017-10-04 21:25           ` Yao Qi
2016-10-28 16:10     ` Yao Qi
2016-10-28 18:41       ` Ulrich Weigand
2016-10-14 10:53 ` [PATCH 1/3] Use get_var_address in test cases Yao Qi
2016-10-14 10:53 ` [RFC 3/3] Update " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1710031902140.21915@tp.orcam.me.uk \
    --to=macro@imgtec.com \
    --cc=bhushan.attarde@imgtec.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox