Re: Your commit 'MIPS/opcodes: Also set disassembler's ASE flags from ELF structures' broke GDB

["Maciej W. Rozycki" <macro@imgtec.com>]

Hi Alan,

On Thu, 15 Dec 2016, Maciej W. Rozycki wrote:

> On Thu, 15 Dec 2016, Alan Modra wrote:
> 
> > >  I'll see if there is something I could do right away as a temporary 
> > > measure to unbreak 32-bit BFD configurations -- I would make the reference 
> > > from `opcodes/mips-dis.c' to `bfd_mips_elf_get_abiflags' weak, however 
> > > regrettably this does not appear supported, so maybe we'll require a dummy 
> > > stub or suchlike hackery if MIPS target support is enabled, but not 
> > > included in BFD.
> > 
> > Make the new ELF code in mips-dis.c conditional on BFD64?
> 
>  Ah, that sounds like the right direction, although I'd rather exclude all 
> MIPS target support (Score wants that too, based on their code) at the 
> `configure' level.  It looks like we handle that already in ld/, by 
> interpreting `want64' and pulling `../bfd/config.bfd' if required, so I'll 
> see if I can import that into binutils/ as well.  Thanks for the hint!

 So I have followed your advice after all and made a minimal change (see 
commit 4df995c77118 ("MIPS/opcodes: Only call `bfd_mips_elf_get_abiflags' 
if BFD64")), because in such a configuration we may still have other MIPS 
BFD targets configured, such as ECOFF, so the disassembler has to remain 
fully functional for `objdump' at least.

  Maciej