From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89776 invoked by alias); 19 Dec 2016 11:49:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89759 invoked by uid 89); 19 Dec 2016 11:49:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=direction, interpreting, HCC:D*net X-Spam-User: qpsmtpd, 2 recipients X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Dec 2016 11:49:36 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id B8CEC1E53C8FE; Mon, 19 Dec 2016 11:49:30 +0000 (GMT) Received: from [10.20.78.31] (10.20.78.31) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Mon, 19 Dec 2016 11:49:32 +0000 Date: Mon, 19 Dec 2016 11:49:00 -0000 From: "Maciej W. Rozycki" To: Alan Modra CC: Antoine Tremblay , , , Subject: Re: Your commit 'MIPS/opcodes: Also set disassembler's ASE flags from ELF structures' broke GDB In-Reply-To: Message-ID: References: <20161215230316.GM10584@bubble.grove.modra.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2016-12/txt/msg00339.txt.bz2 Hi Alan, On Thu, 15 Dec 2016, Maciej W. Rozycki wrote: > On Thu, 15 Dec 2016, Alan Modra wrote: > > > > I'll see if there is something I could do right away as a temporary > > > measure to unbreak 32-bit BFD configurations -- I would make the reference > > > from `opcodes/mips-dis.c' to `bfd_mips_elf_get_abiflags' weak, however > > > regrettably this does not appear supported, so maybe we'll require a dummy > > > stub or suchlike hackery if MIPS target support is enabled, but not > > > included in BFD. > > > > Make the new ELF code in mips-dis.c conditional on BFD64? > > Ah, that sounds like the right direction, although I'd rather exclude all > MIPS target support (Score wants that too, based on their code) at the > `configure' level. It looks like we handle that already in ld/, by > interpreting `want64' and pulling `../bfd/config.bfd' if required, so I'll > see if I can import that into binutils/ as well. Thanks for the hint! So I have followed your advice after all and made a minimal change (see commit 4df995c77118 ("MIPS/opcodes: Only call `bfd_mips_elf_get_abiflags' if BFD64")), because in such a configuration we may still have other MIPS BFD targets configured, such as ECOFF, so the disassembler has to remain fully functional for `objdump' at least. Maciej