From: Ricard Wanderlof <ricard.wanderlof@axis.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix CRISv32 compilation
Date: Fri, 06 Sep 2013 08:09:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1309061005290.3022@lnxricardw.se.axis.com> (raw)
In-Reply-To: <5224CAE7.9090309@redhat.com>
On Mon, 2 Sep 2013, Pedro Alves wrote:
> On 08/30/2013 02:12 PM, Ricard Wanderlof wrote:
>>
>> 2013-08-30 Ricard Wanderlof <ricardw@axis.com>
>>
>> gdbserver
>>
>> * linux-crisv32-low.c: Fix compilation errors.
>
> Write:
>
> * linux-crisv32-low.c (elf_gregset_t): Delete typedef.
> (initialize_low_arch): Call init_registers_crisv32 rather than
> init_register_crisv32.
>
> OK with that change.
>
> (I can't see how the typedef was breaking the build though)
Comitted now.
/Ricard
Fix compilation for target gdbserver on CRISv32 platform.
One misspelled function call, and one superfluous typedef. The latter
causes an error of the following type when building:
linux-crisv32-low.c:372: error: conflicting types for 'elf_gregset_t'
/.../target/include/asm/elf.h:36:
error: previous declaration of 'elf_gregset_t' was here
2013-09-06 Ricard Wanderlof <ricardw@axis.com>
* linux-crisv32-low.c (elf_gregset_t): Delete typedef.
(initialize_low_arch): Call init_registers_crisv32 rather than
init_register_crisv32.
diff --git a/gdb/gdbserver/linux-crisv32-low.c b/gdb/gdbserver/linux-crisv32-low.c
index efe50a7..2849d02 100644
--- a/gdb/gdbserver/linux-crisv32-low.c
+++ b/gdb/gdbserver/linux-crisv32-low.c
@@ -369,8 +369,6 @@ cris_arch_setup (void)
current_process ()->tdesc = tdesc_crisv32;
}
-typedef unsigned long elf_gregset_t[cris_num_regs];
-
static struct regset_info cris_regsets[] = {
{ PTRACE_GETREGS, PTRACE_SETREGS, 0, cris_num_regs * 4,
GENERAL_REGS, cris_fill_gregset, cris_store_gregset },
@@ -426,7 +424,7 @@ struct linux_target_ops the_low_target = {
void
initialize_low_arch (void)
{
- init_register_crisv32 ();
+ init_registers_crisv32 ();
initialize_regsets_info (&cris_regsets_info);
}
--
Ricard Wolf Wanderlöf ricardw(at)axis.com
Axis Communications AB, Lund, Sweden www.axis.com
Phone +46 46 272 2016 Fax +46 46 13 61 30
next prev parent reply other threads:[~2013-09-06 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 13:13 Ricard Wanderlof
2013-09-02 17:29 ` Pedro Alves
[not found] ` <alpine.DEB.2.00.1309030857010.10770@lnxricardw.se.axis.com>
2013-09-03 12:03 ` Pedro Alves
2013-09-03 14:23 ` Ricard Wanderlof
2013-09-06 8:09 ` Ricard Wanderlof [this message]
2013-08-30 13:30 Ricard Wanderlof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1309061005290.3022@lnxricardw.se.axis.com \
--to=ricard.wanderlof@axis.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox