From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1068 invoked by alias); 6 Sep 2013 08:09:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1055 invoked by uid 89); 6 Sep 2013 08:09:32 -0000 Received: from ra.se.axis.com (HELO ra.se.axis.com) (195.60.68.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 08:09:32 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: ra.se.axis.com Received: from localhost (localhost [127.0.0.1]) by ra.se.axis.com (Postfix) with ESMTP id 66C5913ACE; Fri, 6 Sep 2013 10:09:29 +0200 (CEST) Received: from ra.se.axis.com ([127.0.0.1]) by localhost (ra.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lLyEqTeYY-u3; Fri, 6 Sep 2013 10:09:28 +0200 (CEST) Received: from boulder.se.axis.com (boulder.se.axis.com [10.0.2.104]) by ra.se.axis.com (Postfix) with ESMTP id A782013A63; Fri, 6 Sep 2013 10:09:28 +0200 (CEST) Received: from boulder.se.axis.com (localhost [127.0.0.1]) by postfix.imss71 (Postfix) with ESMTP id 2F73B793; Fri, 6 Sep 2013 10:09:28 +0200 (CEST) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by boulder.se.axis.com (Postfix) with ESMTP id 23F1F22F; Fri, 6 Sep 2013 10:09:28 +0200 (CEST) Received: from xmail2.se.axis.com (xmail2.se.axis.com [10.0.5.74]) by thoth.se.axis.com (Postfix) with ESMTP id 224BA3404E; Fri, 6 Sep 2013 10:09:28 +0200 (CEST) Received: from lnxricardw.se.axis.com (10.88.7.1) by xmail2.se.axis.com (10.0.5.74) with Microsoft SMTP Server (TLS) id 8.2.255.0; Fri, 6 Sep 2013 10:09:28 +0200 Date: Fri, 06 Sep 2013 08:09:00 -0000 From: Ricard Wanderlof To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix CRISv32 compilation In-Reply-To: <5224CAE7.9090309@redhat.com> Message-ID: References: <5224CAE7.9090309@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8BIT X-SW-Source: 2013-09/txt/msg00204.txt.bz2 On Mon, 2 Sep 2013, Pedro Alves wrote: > On 08/30/2013 02:12 PM, Ricard Wanderlof wrote: >> >> 2013-08-30 Ricard Wanderlof >> >> gdbserver >> >> * linux-crisv32-low.c: Fix compilation errors. > > Write: > > * linux-crisv32-low.c (elf_gregset_t): Delete typedef. > (initialize_low_arch): Call init_registers_crisv32 rather than > init_register_crisv32. > > OK with that change. > > (I can't see how the typedef was breaking the build though) Comitted now. /Ricard Fix compilation for target gdbserver on CRISv32 platform. One misspelled function call, and one superfluous typedef. The latter causes an error of the following type when building: linux-crisv32-low.c:372: error: conflicting types for 'elf_gregset_t' /.../target/include/asm/elf.h:36: error: previous declaration of 'elf_gregset_t' was here 2013-09-06 Ricard Wanderlof * linux-crisv32-low.c (elf_gregset_t): Delete typedef. (initialize_low_arch): Call init_registers_crisv32 rather than init_register_crisv32. diff --git a/gdb/gdbserver/linux-crisv32-low.c b/gdb/gdbserver/linux-crisv32-low.c index efe50a7..2849d02 100644 --- a/gdb/gdbserver/linux-crisv32-low.c +++ b/gdb/gdbserver/linux-crisv32-low.c @@ -369,8 +369,6 @@ cris_arch_setup (void) current_process ()->tdesc = tdesc_crisv32; } -typedef unsigned long elf_gregset_t[cris_num_regs]; - static struct regset_info cris_regsets[] = { { PTRACE_GETREGS, PTRACE_SETREGS, 0, cris_num_regs * 4, GENERAL_REGS, cris_fill_gregset, cris_store_gregset }, @@ -426,7 +424,7 @@ struct linux_target_ops the_low_target = { void initialize_low_arch (void) { - init_register_crisv32 (); + init_registers_crisv32 (); initialize_regsets_info (&cris_regsets_info); } -- Ricard Wolf Wanderlöf ricardw(at)axis.com Axis Communications AB, Lund, Sweden www.axis.com Phone +46 46 272 2016 Fax +46 46 13 61 30