[PATCH 1/2][CRIS/CRISv32] Remove host system dependency in cris-tdep.c (fwd)

[PATCH 1/2][CRIS/CRISv32] Remove host system dependency in cris-tdep.c (fwd)

[Ricard Wanderlof]

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]


This patch removes a host system dependency from cris-tdep.c . The
original version of this patch has been floating around for several years
now in our local repository so it's way overdue pushing upstream. Tested
by doing a small debugging session against a remote gdbserver running on a
target system.

Patch included inline for review and as attachement for use.


Signed-off-by: Ricard Wanderlof <ricardw@axis.com>


2013-09-03  Ricard Wanderlof  <ricardw@axis.com>

 	* cris-tdep.c: Use host independent typedef for elf_greg_t.


diff --git a/gdb/cris-tdep.c b/gdb/cris-tdep.c
index 03041e4..80ab1b8 100644
--- a/gdb/cris-tdep.c
+++ b/gdb/cris-tdep.c
@@ -3820,7 +3820,7 @@ cris_delayed_get_disassembler (bfd_vma addr, struct disassemble_info *info)
   }

   /* Copied from <asm/elf.h>.  */
-typedef unsigned long elf_greg_t;
+typedef unsigned char elf_greg_t[4];

   /* Same as user_regs_struct struct in <asm/user.h>.  */
   #define CRISV10_ELF_NGREG 35


/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch file.patch --]
[-- Type: text/x-diff; name="cris-head-no-hostdep.patch", Size: 432 bytes --]

diff --git a/gdb/cris-tdep.c b/gdb/cris-tdep.c
index 03041e4..80ab1b8 100644
--- a/gdb/cris-tdep.c
+++ b/gdb/cris-tdep.c
@@ -3820,7 +3820,7 @@ cris_delayed_get_disassembler (bfd_vma addr, struct disassemble_info *info)
 }
 
 /* Copied from <asm/elf.h>.  */
-typedef unsigned long elf_greg_t;
+typedef unsigned char elf_greg_t[4];
 
 /* Same as user_regs_struct struct in <asm/user.h>.  */
 #define CRISV10_ELF_NGREG 35

Re: [PATCH 1/2][CRIS/CRISv32] Remove host system dependency in cris-tdep.c (fwd)

[Pedro Alves]

On 09/03/2013 03:17 PM, Ricard Wanderlof wrote:

> 2013-09-03  Ricard Wanderlof  <ricardw@axis.com>
> 
>  	* cris-tdep.c: Use host independent typedef for elf_greg_t.

Write, e.g.:

  	* cris-tdep.c (elf_greg_t): Change typedef to unsigned char[4].

See:

 https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog

OK with that change.

Thanks,
-- 
Pedro Alves

Re: [PATCH 1/2][CRIS/CRISv32] Remove host system dependency in cris-tdep.c (fwd)

[Ricard Wanderlof]

On Tue, 3 Sep 2013, Pedro Alves wrote:

> On 09/03/2013 03:17 PM, Ricard Wanderlof wrote:
>
>> 2013-09-03  Ricard Wanderlof  <ricardw@axis.com>
>>
>>  	* cris-tdep.c: Use host independent typedef for elf_greg_t.
>
> Write, e.g.:
>
>  	* cris-tdep.c (elf_greg_t): Change typedef to unsigned char[4].
>
> See:
>
> https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog
>
> OK with that change.

Fine by me, of course.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30

Re: [PATCH 1/2][CRIS/CRISv32] Remove host system dependency in cris-tdep.c (fwd)

[Pedro Alves]

I don't see you listed in gdb/MAINTAINERS.  Are you setup to
commit your own patches, or have someone to do it for you?  If not,
and you're going to be submitting patches going forward, then it'd
probably just be better to get you write access.

-- 
Pedro Alves

Re: [PATCH 1/2][CRIS/CRISv32] Remove host system dependency in cris-tdep.c (fwd)

[Hans-Peter Nilsson]

On Tue, 3 Sep 2013, Pedro Alves wrote:
> I don't see you listed in gdb/MAINTAINERS.  Are you setup to
> commit your own patches, or have someone to do it for you?  If not,
> and you're going to be submitting patches going forward, then it'd
> probably just be better to get you write access.

I was going to handle that part (uh, eventually :) but Ricard
can do that himself when he gets an account.  There's a general
copyright assignment including gdb from Axis Communications at
the FSF which should cover the formalia together with the
approval of the patches just sent.  (Pedro beat me to it!)

Being an authorised committer for the CRIS port (admittedly a
lazy one at that and also quickly losing lost track of patches
not CC:ed ;) I believe I can recommend Ricard for an account.
Ricard, please use the form at
http://sourceware.org/cgi-bin/pdw/ps_form.cgi (use my Axis
address in the approver field).

brgds, H-P

Re: [PATCH 1/2][CRIS/CRISv32] Remove host system dependency in cris-tdep.c (fwd)

[Ricard Wanderlof]

On Wed, 4 Sep 2013, Hans-Peter Nilsson wrote:

> On Tue, 3 Sep 2013, Pedro Alves wrote:
>> I don't see you listed in gdb/MAINTAINERS.  Are you setup to
>> commit your own patches, or have someone to do it for you?  If not,
>> and you're going to be submitting patches going forward, then it'd
>> probably just be better to get you write access.
>
> I was going to handle that part (uh, eventually :) but Ricard
> can do that himself when he gets an account.  There's a general
> copyright assignment including gdb from Axis Communications at
> the FSF which should cover the formalia together with the
> approval of the patches just sent.  (Pedro beat me to it!)
>
> Being an authorised committer for the CRIS port (admittedly a
> lazy one at that and also quickly losing lost track of patches
> not CC:ed ;) I believe I can recommend Ricard for an account.
> Ricard, please use the form at
> http://sourceware.org/cgi-bin/pdw/ps_form.cgi (use my Axis
> address in the approver field).

Well, quite frankly, I don't know how much submitting I will be doing in 
practice, at the moment I'm between projects and can put some time into 
this, but in general it's very limited. Nevertheless I think write access 
would be a good idea so everything doesn't have to go through H-P here.

H-P, I've filled in the form anyway.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30

Re: [PATCH 1/2][CRIS/CRISv32] Remove host system dependency in cris-tdep.c

[Ricard Wanderlof]

On Tue, 3 Sep 2013, Pedro Alves wrote:

> On 09/03/2013 03:17 PM, Ricard Wanderlof wrote:
>
>> 2013-09-03  Ricard Wanderlof  <ricardw@axis.com>
>>
>>  	* cris-tdep.c: Use host independent typedef for elf_greg_t.
>
> Write, e.g.:
>
>  	* cris-tdep.c (elf_greg_t): Change typedef to unsigned char[4].
>
> OK with that change.

Comitted now.

/Ricard


Trivial patch to remove dependency on host unsigned long type
from cris-tdep.c.


2013-09-06  Ricard Wanderlof  <ricardw@axis.com>

 	* cris-tdep.c (elf_greg_t): Change typedef to unsigned char[4]


diff --git a/gdb/cris-tdep.c b/gdb/cris-tdep.c
index 03041e4..80ab1b8 100644
--- a/gdb/cris-tdep.c
+++ b/gdb/cris-tdep.c
@@ -3820,7 +3820,7 @@ cris_delayed_get_disassembler (bfd_vma addr, struct disassemble_info *info)
  }

  /* Copied from <asm/elf.h>.  */
-typedef unsigned long elf_greg_t;
+typedef unsigned char elf_greg_t[4];

  /* Same as user_regs_struct struct in <asm/user.h>.  */
  #define CRISV10_ELF_NGREG 35

-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30