Re: [PATCH] GDB/testsuite: Correct gdb.base/watchpoint-solib.exp timeout tweak

["Maciej W. Rozycki" <macro@codesourcery.com>]

On Tue, 29 Jul 2014, Pedro Alves wrote:

> >  Tested on arm-linux-gnueabi.  OK to apply?
> 
> OK

 Applied now, thanks.

> > +
> > +set savedtimeout $timeout
> > +if { [target_info exists gdb,timeout]
> > +     && $timeout < [target_info gdb,timeout] } {
> > +    set oldtimeout [target_info gdb,timeout]
> > +} else {
> > +    set oldtimeout $timeout
> > +}
> > +set timeout [expr $oldtimeout * 30]
> 
> Clearly this pattern is going to be popping in more
> places going forward.  Maybe we should even consider factoring
> it out to a with_test_prefix-like procedure.  Something like:
> 
>  proc with_timeout_factor { factor } {
>    ...
>  }
> 
>  with_timeout_factor 30 {
>     ...
>     gdb_test "continue" ".*Breakpoint 2.*foo.*" "continue to foo again"
>     ...
>  }

 Just as with the gdb.reverse change, I agree this is a good idea and I'll 
keep it in my mind as a future improvement (honestly I'd rather use my 
next available slot for GDB development though to get the outstanding 
microMIPS and MIPS FP stuff dusted off and resubmitted, so this stuff will 
only be for the second next slot or suchlike ;) ).

  Maciej