From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-115648-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18099 invoked by alias); 9 Sep 2014 16:47:56 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18087 invoked by uid 89); 9 Sep 2014 16:47:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Sep 2014 16:47:55 +0000
Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com)	by relay1.mentorg.com with esmtp 	id 1XROa7-0003Za-JM from Maciej_Rozycki@mentor.com ; Tue, 09 Sep 2014 09:47:51 -0700
Received: from localhost (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 9 Sep 2014 17:47:50 +0100
Date: Tue, 09 Sep 2014 16:47:00 -0000
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] GDB/testsuite: Correct gdb.base/watchpoint-solib.exp timeout tweak
In-Reply-To: <53D79736.5000100@redhat.com>
Message-ID: <alpine.DEB.1.10.1409091743400.27075@tp.orcam.me.uk>
References: <alpine.DEB.1.10.1407291303120.16254@tp.orcam.me.uk> <53D79736.5000100@redhat.com>
User-Agent: Alpine 1.10 (DEB 962 2008-03-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-SW-Source: 2014-09/txt/msg00239.txt.bz2

On Tue, 29 Jul 2014, Pedro Alves wrote:

> >  Tested on arm-linux-gnueabi.  OK to apply?
> 
> OK

 Applied now, thanks.

> > +
> > +set savedtimeout $timeout
> > +if { [target_info exists gdb,timeout]
> > +     && $timeout < [target_info gdb,timeout] } {
> > +    set oldtimeout [target_info gdb,timeout]
> > +} else {
> > +    set oldtimeout $timeout
> > +}
> > +set timeout [expr $oldtimeout * 30]
> 
> Clearly this pattern is going to be popping in more
> places going forward.  Maybe we should even consider factoring
> it out to a with_test_prefix-like procedure.  Something like:
> 
>  proc with_timeout_factor { factor } {
>    ...
>  }
> 
>  with_timeout_factor 30 {
>     ...
>     gdb_test "continue" ".*Breakpoint 2.*foo.*" "continue to foo again"
>     ...
>  }

 Just as with the gdb.reverse change, I agree this is a good idea and I'll 
keep it in my mind as a future improvement (honestly I'd rather use my 
next available slot for GDB development though to get the outstanding 
microMIPS and MIPS FP stuff dusted off and resubmitted, so this stuff will 
only be for the second next slot or suchlike ;) ).

  Maciej