From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Alan Modra <amodra@gmail.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] MIPS: Compressed PLT/stubs support
Date: Sat, 09 Mar 2013 04:06:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1303090404460.21335@tp.orcam.me.uk> (raw)
In-Reply-To: <87obfc6rga.fsf@fleche.redhat.com>
On Fri, 22 Feb 2013, Tom Tromey wrote:
> Alan> Hmm, perhaps a cleaner change would be implement make_msymbol_special
> Alan> for ppc64 and move the udata.p special case out of elf_symtab_read?
>
> Alan> Like so.
>
> Alan> * elfread.c (elf_symtab_read): Do not use udata.p here to find
> Alan> symbol size.
> Alan> * ppc64-tdep.c (ppc64_elf_make_msymbol_special): New function.
> Alan> * ppc64-tdep.h (ppc64_elf_make_msymbol_special): Declare.
> Alan> * ppc-linux-tdep.c (ppc_linux_init_abi): Set up to use the above.
> Alan> * ppcfbsd-tdep.c (ppcfbsd_init_abi): Likewise.
>
> I like this much better, thanks.
> This is ok.
Thanks for sorting this out -- now the MIPS change does not have to touch
elfread.c anymore.
Maciej
next prev parent reply other threads:[~2013-03-09 4:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 20:44 Maciej W. Rozycki
2013-02-19 20:45 ` [PATCH 2/2] MIPS: Compressed PLT/stubs support test cases Maciej W. Rozycki
2013-02-20 21:53 ` [PATCH 1/2] MIPS: Compressed PLT/stubs support Richard Sandiford
2013-03-09 4:04 ` Maciej W. Rozycki
2013-03-09 9:58 ` Richard Sandiford
2013-06-08 0:22 ` Maciej W. Rozycki
2013-06-08 16:04 ` Richard Sandiford
2013-06-10 17:13 ` Maciej W. Rozycki
2013-06-10 18:08 ` Richard Sandiford
2013-06-10 19:34 ` Maciej W. Rozycki
2013-06-25 0:40 ` Maciej W. Rozycki
2013-03-11 13:53 ` Joel Brobecker
2013-06-26 15:02 ` Maciej W. Rozycki
2013-02-21 21:06 ` Tom Tromey
2013-02-22 0:58 ` Alan Modra
2013-02-22 6:06 ` Alan Modra
2013-02-22 20:09 ` Tom Tromey
2013-03-09 4:06 ` Maciej W. Rozycki [this message]
2013-06-20 16:20 ` [PING^2][PATCH] in_plt_section: support alternate stub section names (was: [PATCH 1/2] MIPS: Compressed PLT/stubs support) Maciej W. Rozycki
2013-06-20 16:50 ` [PING^2][PATCH] in_plt_section: support alternate stub section names Pedro Alves
2013-06-21 11:43 ` Maciej W. Rozycki
2013-06-21 15:34 ` Pedro Alves
2013-06-22 2:24 ` Maciej W. Rozycki
2013-06-24 12:40 ` Pedro Alves
2013-06-24 23:34 ` Maciej W. Rozycki
2013-06-25 9:57 ` Pedro Alves
2013-06-07 13:25 ` [PATCH] in_plt_section: support alternate stub section names (was: [PATCH 1/2] MIPS: Compressed PLT/stubs support) Maciej W. Rozycki
2013-06-13 12:43 ` [PING][PATCH] " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1303090404460.21335@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=amodra@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox