From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10453 invoked by alias); 9 Mar 2013 04:06:54 -0000 Received: (qmail 10442 invoked by uid 22791); 9 Mar 2013 04:06:53 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 09 Mar 2013 04:06:45 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UEB3U-0004Rx-8b from Maciej_Rozycki@mentor.com ; Fri, 08 Mar 2013 20:06:44 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 8 Mar 2013 20:06:44 -0800 Received: from [172.30.64.154] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Sat, 9 Mar 2013 04:06:41 +0000 Date: Sat, 09 Mar 2013 04:06:00 -0000 From: "Maciej W. Rozycki" To: Tom Tromey CC: Alan Modra , Subject: Re: [PATCH 1/2] MIPS: Compressed PLT/stubs support In-Reply-To: <87obfc6rga.fsf@fleche.redhat.com> Message-ID: References: <87wqu19y1x.fsf@fleche.redhat.com> <20130222005833.GJ3080@bubble.grove.modra.org> <20130222060640.GL3080@bubble.grove.modra.org> <87obfc6rga.fsf@fleche.redhat.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00411.txt.bz2 On Fri, 22 Feb 2013, Tom Tromey wrote: > Alan> Hmm, perhaps a cleaner change would be implement make_msymbol_special > Alan> for ppc64 and move the udata.p special case out of elf_symtab_read? > > Alan> Like so. > > Alan> * elfread.c (elf_symtab_read): Do not use udata.p here to find > Alan> symbol size. > Alan> * ppc64-tdep.c (ppc64_elf_make_msymbol_special): New function. > Alan> * ppc64-tdep.h (ppc64_elf_make_msymbol_special): Declare. > Alan> * ppc-linux-tdep.c (ppc_linux_init_abi): Set up to use the above. > Alan> * ppcfbsd-tdep.c (ppcfbsd_init_abi): Likewise. > > I like this much better, thanks. > This is ok. Thanks for sorting this out -- now the MIPS change does not have to touch elfread.c anymore. Maciej