Re: [RFA 1/2] mips: Switch inferior function calls to ON_STACK method.

["Maciej W. Rozycki" <macro@codesourcery.com>]

On Fri, 4 May 2012, Mark Kettenis wrote:

> > >  Understood, but I'd be happier if the comment you're removing or a 
> > > similar stayed in place.  If by trap you mean SIGTRAP, then I think this 
> > > is not going to be the case.
> > 
> > I think you refer to the comment from Andrew Cagney? I've put it back
> > as is.
> 
> I really don't think that comment is helpful anymore.  Almost ten
> years have gone by without anyone feeling the need to implement the
> command Andrew is alluding to here,

 I referred to the non-executable stack behaviour, not the command wished 
for, sorry if I worded that ambiguously.

> > OK to commit, modulo the possible rename above?
> 
> Seems you missed my comment about the the mips_frame_align() call.
> It's unecessary since the frame is already properly aligned by the
> calles of push_dummy_code().

 Indeed.

> > +/* Implement the push_dummy_code gdbarch method for mips targets.  */
> 
> Perhaps change that comment into:
> 
>   /* Implement the "push_dummy_call" gdbarch method.  */
> 
> such that it is consistent with the style of comments in rl78-tdep.c
> and rx-tdep.c and moxie-tdep.c?  The "for mips targets" isn't really
> adding any information (and might end up accidentally being copied).

 As per my suggestion I think it makes sense to document any peculiarities 
of this specific implementation here as well (in this case the safety to 
use with non-executable stack).

  Maciej