From: Pedro Alves <palves@redhat.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp
Date: Fri, 27 May 2016 12:48:00 -0000 [thread overview]
Message-ID: <af96f633-8225-75ee-a0a4-0b40bb40d372@redhat.com> (raw)
In-Reply-To: <wwokshx3vfu8.fsf@ericsson.com>
On 05/27/2016 01:35 PM, Antoine Tremblay wrote:
>
> Pedro Alves writes:
>
>> On 05/17/2016 06:03 PM, Antoine Tremblay wrote:
>>> The test coverage remains the same.
>>
>> How did you determine it that it's the same?
>
> I've put an assert in each emit function and validated that they are all
> called before / after the move.
That's excellent, and it's the sort of info that should be
explicitly mentioned in the commit log.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-05-27 12:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 17:03 Antoine Tremblay
2016-05-17 17:03 ` [PATCH 2/4] Add emit_less_unsigned test in trace-condition.exp Antoine Tremblay
2016-05-27 12:02 ` Pedro Alves
2016-05-27 12:36 ` Antoine Tremblay
2016-05-17 17:03 ` [PATCH 3/4] Add variable length tests for emit_ref " Antoine Tremblay
2016-05-27 12:05 ` Pedro Alves
2016-05-27 13:04 ` Antoine Tremblay
2016-05-17 17:03 ` [PATCH 4/4] Add tests for 64bit values " Antoine Tremblay
2016-05-27 12:08 ` Pedro Alves
2016-05-27 12:36 ` Antoine Tremblay
2016-05-27 12:00 ` [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp Pedro Alves
2016-05-27 12:35 ` Antoine Tremblay
2016-05-27 12:48 ` Pedro Alves [this message]
2016-05-27 12:51 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af96f633-8225-75ee-a0a4-0b40bb40d372@redhat.com \
--to=palves@redhat.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox