From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131787-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 101686 invoked by alias); 27 May 2016 12:48:03 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 101653 invoked by uid 89); 27 May 2016 12:48:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=(unknown)
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 May 2016 12:48:01 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 91F5AC062D1F;	Fri, 27 May 2016 12:48:00 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4RClx5O010753;	Fri, 27 May 2016 08:47:59 -0400
Subject: Re: [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
References: <1463504594-4419-1-git-send-email-antoine.tremblay@ericsson.com> <b5a368d3-91ab-2ed2-4a73-efe792d9e88c@redhat.com> <wwokshx3vfu8.fsf@ericsson.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <af96f633-8225-75ee-a0a4-0b40bb40d372@redhat.com>
Date: Fri, 27 May 2016 12:48:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <wwokshx3vfu8.fsf@ericsson.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-05/txt/msg00493.txt.bz2

On 05/27/2016 01:35 PM, Antoine Tremblay wrote:
> 
> Pedro Alves writes:
> 
>> On 05/17/2016 06:03 PM, Antoine Tremblay wrote:

>>> The test coverage remains the same.
>>
>> How did you determine it that it's the same?
> 
> I've put an assert in each emit function and validated that they are all
> called before / after the move.

That's excellent, and it's the sort of info that should be
explicitly  mentioned in the commit log.

Thanks,
Pedro Alves